From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1355 invoked by alias); 2 Mar 2003 02:01:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1348 invoked from network); 2 Mar 2003 02:01:05 -0000 Received: from unknown (HELO localhost.redhat.com) (205.151.14.167) by 172.16.49.205 with SMTP; 2 Mar 2003 02:01:05 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 99F132B04; Sat, 1 Mar 2003 21:03:02 -0500 (EST) Message-ID: <3E616656.5020500@redhat.com> Date: Sun, 02 Mar 2003 02:01:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: The ari hits References: <3E5E8CAA.1080304@redhat.com> <20030228015238.GA17237@nevyn.them.org> <3E5FA2D8.3020706@redhat.com> <20030228175939.GA13177@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00019.txt.bz2 >> REGISTER_VIRTUAL_SIZE (...) /* OK */ >> >> (the ``/* OK */'' gags the ARI) and add a comment. >> >> sorry about this, > > > That makes a lot more sense now, thank you! I just assumed you were > implying the gdbarch_ prefix. > > Here's another question, though. frame_register may return a cooked > value, but frame_saved_regs_register_unwind uses a buffer of > REGISTER_RAW_SIZE. Is using REGISTER_VIRTUAL_SIZE in core code really > safe? Hmm, no, sorry. It's the value_of_register() value_from_register() code that plays with virtual_size, not frame_register() et.al. On the bright side, this means that it can use register_size() as that, when given a choice, should return the raw size. Andrew