From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5259 invoked by alias); 28 Feb 2003 17:54:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5252 invoked from network); 28 Feb 2003 17:54:27 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 28 Feb 2003 17:54:27 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7D2932A9C; Fri, 28 Feb 2003 12:56:40 -0500 (EST) Message-ID: <3E5FA2D8.3020706@redhat.com> Date: Fri, 28 Feb 2003 17:54:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: The ari hits References: <3E5E8CAA.1080304@redhat.com> <20030228015238.GA17237@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00822.txt.bz2 > On Thu, Feb 27, 2003 at 05:09:46PM -0500, Andrew Cagney wrote: > >> Daniel, >> >> The files you recently committed trip the ARI. Can you please check >> this out. >> >> Andrew >> >> http://sources.redhat.com/gdb/current/ari/ > > > Thanks for reminding me; this patch fixes them. Almost obvious except > for a bit that I want your opinion on - the hint on the ARI > says to use register_size but I'm not convinced that's right. Is > gdbarch_register_size always big enough that I don't need to use > gdbarch_register_raw_size? You're correct, however, so is the comment - use register_size() (not gdbarch_register_size). The problem is that I forgot to add that function to regcache.[ch] :-( I've just done this. There is also a bigger problem here. Because some targets still have differring raw and cooked register sizes (read MIPS), things get messy. frame_register() returns a `cooked' register value so, for the moment, I'd use: REGISTER_VIRTUAL_SIZE (...) /* OK */ (the ``/* OK */'' gags the ARI) and add a comment. sorry about this, Andrew