Michal Ludvig wrote:
> Daniel Jacobowitz wrote:
> 
>> In any case I am withdrawing my attempt to be helpful, since obviously
>> I'm being pushy again instead of helpful.  Michal can go back to
>> waiting for someone else's response since my "help" has obviously
>> injured the entire process.
> 
> Thank you very much, anyway! You at least attempted to solve this issue.
> Other "responsible" maintainers didn't bother to respond until you 
> approved my patch. Then Andrew felt he should step in, revert your 
> approval and say NO (why there doesn't come a *constructive* critique 
> along with your no, Andrew?). And Elena - apparently the only one who 
> could say yes - disappeared... Sigh.
> 
> I'm asking once again:
> - Can I *at* *least* commit the dwarf2cfi.c part? Without the infcmd.c 
> hook? I know it duplicates the solib cleaner logic, but is that a 
> showstopper?
> - Ad run_command() hook - would something like this be acceptable?
> 
> Index: config/i386/tm-x86-64linux.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/config/i386/tm-x86-64linux.h,v
> retrieving revision 1.1
> diff -u -p -r1.1 tm-x86-64linux.h
> --- config/i386/tm-x86-64linux.h        1 Jul 2002 22:09:52 -0000       1.1
> +++ config/i386/tm-x86-64linux.h        27 Feb 2003 08:02:50 -0000
> @@ -33,4 +33,6 @@
>  #define SVR4_SHARED_LIBS
>  #include "solib.h"              /* Support for shared libraries. */
> 
> +#define DWARF2CFI_USED
> +
>  #endif /* #ifndef TM_X86_64LINUX_H */
> Index: infcmd.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/infcmd.c,v
> retrieving revision 1.54.6.2
> diff -u -p -r1.54.6.2 infcmd.c
> --- infcmd.c    25 Sep 2002 20:43:21 -0000      1.54.6.2
> +++ infcmd.c    27 Feb 2003 08:02:50 -0000
> @@ -390,6 +390,10 @@ Start it from the beginning? "))
> 
>    clear_breakpoint_hit_counts ();
> 
> +#if defined(DWARF2CFI_USED)
> +  cleanup_cfi ();
> +#endif
> +
>    /* Purge old solib objfiles. */
>    objfile_purge_solibs ();
> 
> Every target that will use the CFI engine will just add one define to 
> their tm.h. No need to link dwarf2cfi.o to all targets.

I've extended this approach a little bit. Now it's enough to define 
USED_DWARF2CFI=1 in config/arch/target.mh file and everything will be 
configured automatically, ie. dwarf2cfi.o will be added to the list of 
files to compile and -DUSED_DWARF2CFI=1 will be added to CFLAGS.
So only those targets that explicitly say "Yes, I want CFI engine" will 
have it and the run_command cleanup hook will go in for them as well.

Is this a way to go?

Michal Ludvig
-- 
* SuSE CR, s.r.o     * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz