From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25395 invoked by alias); 26 Feb 2003 22:07:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25388 invoked from network); 26 Feb 2003 22:07:40 -0000 Received: from unknown (HELO kerberos.suse.cz) (195.47.106.10) by 172.16.49.205 with SMTP; 26 Feb 2003 22:07:40 -0000 Received: from chimera.suse.cz (chimera.suse.cz [10.20.0.2]) by kerberos.suse.cz (SuSE SMTP server) with ESMTP id 6C13159D35E; Wed, 26 Feb 2003 23:07:39 +0100 (CET) Received: from suse.cz (naga.suse.cz [10.20.1.16]) by chimera.suse.cz (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id h1QM7d425149; Wed, 26 Feb 2003 23:07:39 +0100 X-Authentication-Warning: chimera.suse.cz: Host naga.suse.cz [10.20.1.16] claimed to be suse.cz Message-ID: <3E5D3AAA.4070106@suse.cz> Date: Wed, 26 Feb 2003 22:07:00 -0000 From: Michal Ludvig Organization: SuSE CR User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: cs, cz, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: GDB Patches Subject: Re: [RFA] Dwarf2CFI fix References: <3E5CF5F5.10300@suse.cz> <20030226172553.GA14094@nevyn.them.org> In-Reply-To: <20030226172553.GA14094@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00753.txt.bz2 Daniel Jacobowitz wrote: > Either you're missing a bit of a patch or you're missing a bit of a > changelog. And there's no changelog entry for struct eh_frame either. Oops, sorry. The changelog wasn't yet saved while I was sending the mail... Here it goes: 2003-02-26 Michal Ludvig * dwarf2cfi.c (struct cie_unit): Added eh_frame field. (parse_frame_info): It's not true that FDEs always refer to the last CIE. We must deal with such a situation. >>diff -upr gdb-upto-08/dwarf2cfi.c gdb/dwarf2cfi.c >>--- gdb-upto-08/dwarf2cfi.c 2003-02-26 10:20:02.000000000 +0100 >>+++ gdb/dwarf2cfi.c 2003-02-26 17:17:30.000000000 +0100 >>@@ -50,6 +50,10 @@ struct cie_unit >> char *data; >> unsigned int data_length; >> >>+ /* This field is 1 for CIE from .eh_frame >>+ and 0 for one from .debug_frame. */ > > > Formatting: don't wrap that early, and two spaces after a period. OK, I'll reindent it with gdb_indent.sh before committing. > The patch itself looks OK. Is this an approval? :-) Michal Ludvig -- * SuSE CR, s.r.o * mludvig@suse.cz * (+420) 296.545.373 * http://www.suse.cz