From: "J. Johnston" <jjohnstn@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: RFA: infptrace fix
Date: Mon, 24 Feb 2003 23:31:00 -0000 [thread overview]
Message-ID: <3E5AAB5F.1070408@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
The following patch fixes a problem on linux regarding attached
processes. When gdb quits, it goes to detach the process. If the
process has already been killed, the ptrace detach call sets errno.
This causes infptrace.c: detach() to issue a perror_with_name()
call which eventually gets caught and the user is returned to the
gdb prompt. If we try and quit again, we go through the same
sequence and so on and so on.
The patch recognizes if errno is set to ESRCH, indicating that the
process cannot be found which is ok and should not result in an
error being flagged.
Ok to install?
-- Jeff J.
2003-02-24 Jeff Johnston <jjohnstn@redhat.com>
* infptrace.c (detach): Do not flag error if ptrace detach fails and
errno is set to ESRCH.
[-- Attachment #2: infptrace.patch --]
[-- Type: text/plain, Size: 495 bytes --]
Index: infptrace.c
===================================================================
RCS file: /cvs/src/src/gdb/infptrace.c,v
retrieving revision 1.22
diff -u -r1.22 infptrace.c
--- infptrace.c 8 Nov 2002 23:48:38 -0000 1.22
+++ infptrace.c 24 Feb 2003 23:26:22 -0000
@@ -301,7 +301,7 @@
errno = 0;
ptrace (PT_DETACH, PIDGET (inferior_ptid), (PTRACE_ARG3_TYPE) 1,
signal);
- if (errno)
+ if (errno && errno != ESRCH)
perror_with_name ("ptrace");
attach_flag = 0;
}
next reply other threads:[~2003-02-24 23:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 23:31 J. Johnston [this message]
2003-02-25 0:10 ` Kevin Buettner
2003-02-25 19:40 ` J. Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E5AAB5F.1070408@redhat.com \
--to=jjohnstn@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox