From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3899 invoked by alias); 24 Feb 2003 21:46:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3882 invoked from network); 24 Feb 2003 21:46:49 -0000 Received: from unknown (HELO mallaury.noc.nerim.net) (62.4.17.102) by 172.16.49.205 with SMTP; 24 Feb 2003 21:46:49 -0000 Received: from nerim.fr (stcarrez.net1.nerim.net [62.212.108.40]) by mallaury.noc.nerim.net (Postfix) with ESMTP id 9780A62D05; Mon, 24 Feb 2003 22:46:45 +0100 (CET) Message-ID: <3E5A92C7.4070205@nerim.fr> Date: Mon, 24 Feb 2003 21:46:00 -0000 From: Stephane Carrez User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4.1) Gecko/20020508 Netscape6/6.2.3 X-Accept-Language: en-us MIME-Version: 1.0 To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix testsuite/gdb.base/break.exp when test compiled with -DPROTOTYPES References: <3E5A8C4F.7020000@nerim.fr> <15962.37096.719113.658720@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00607.txt.bz2 Hi Elena, Elena Zannoni wrote: > Stephane Carrez writes: > > Hi! > > > > In the gdb.base/break.c test, the function marker4() is defined at line 46 when > > the test is compiled with -DPROTOTYPES and at line 51 otherwise. The break.exp > > test only check for line 51. > > > > This patch adds the missing regexp for marker4 at line 46. > > (tested with make check for m6811-elf; break.exp passes completely) > > > > Can you approve it? > > > > Could this be fixed by adding a comment to the lines in question, > use gdb_get_line_number, and use that in the test? > It's not good because marker4() is defined at 2 different lines. If we use gdb_get_line_number() it will always find the first match which is at 46 and the test will fail for targets that don't compile their tests with -DPROTOTYPES. Stephane