From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5520 invoked by alias); 21 Feb 2003 01:48:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5513 invoked from network); 21 Feb 2003 01:48:14 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 21 Feb 2003 01:48:14 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 26A632EF9; Thu, 20 Feb 2003 20:52:55 -0500 (EST) Message-ID: <3E558676.4070605@redhat.com> Date: Fri, 21 Feb 2003 01:48:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.0.2) Gecko/20030217 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: ppc_linux_init_extra_frame_info References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00509.txt.bz2 Andreas, given my comments, I think this fix is pretty funny :-) > - behavior is ever fixed.) > - > - PC_IN_SIGTRAMP is called from blockframe.c as well in order to set > - the frame's type (if a SIGTRAMP_FRAME). Because of our strange > - definition of in_sigtramp below, we can't rely on the frame's type > - getting set correctly from within blockframe.c. This is why we > - take pains to set it in init_extra_frame_info(). > - > - NOTE: cagney/2002-11-10: I suspect the real problem here is that > - the get_prev_frame() only initializes the frame's type after the > - call to INIT_FRAME_INFO. get_prev_frame() should be fixed, this > - code shouldn't be working its way around a bug :-(. */ > + behavior is ever fixed.) */ > > int > ppc_linux_in_sigtramp (CORE_ADDR pc, char *func_name) > @@ -374,10 +363,6 @@ ppc_linux_init_extra_frame_info (int fro > at trampoline code */ > if (ppc_linux_at_sigtramp_return_path (fi->pc)) > deprecated_set_frame_type (fi, SIGTRAMP_FRAME); > - else > - /* FIXME: cagney/2002-11-10: Is this double bogus? What > - happens if the frame has previously been marked as a dummy? */ > - deprecated_set_frame_type (fi, NORMAL_FRAME);