Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: "Martin M. Hunt" <hunt@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] fix AIX builds
Date: Thu, 20 Feb 2003 13:04:00 -0000	[thread overview]
Message-ID: <3E54D379.3060900@redhat.com> (raw)
In-Reply-To: <1045719632.1640.4.camel@Dragon>

> AIX builds are failing because CONFIG_LDFLAGS is getting set to
> -lpthdebug which results in the library being linked before all the
> object files.  The library needs to be after the object files and
> CONFIG_LDFLAGS is for flags not libraries. This patch basically reverts
> a previous one from a few months ago. There might be a better way to do
> this but this seems to work OK for me.
> 
> 2003-02-19  Martin M. Hunt  <hunt@redhat.com>
> 
> 	* configure.in: Don't set CONFIG_LDFLAGS to -lpthdebug.
> 	* config/powerpc/aix432.mh (NAT_CLIBS): Set to -lpthdebug.
> 
> 

This is configure, approval isn't needed.  How quickly you commit 
something depends on how lucky you feel.  Do you feel lucky? :-)

> +# pthread debugging support
> +NAT_CLIBS = -lpthdebug

Given it reverts something, you'll want to add comments explaining why 
it didn't work the other way.

Andrew



  reply	other threads:[~2003-02-20 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-20  5:40 Martin M. Hunt
2003-02-20 13:04 ` Andrew Cagney [this message]
2003-02-20 15:04 ` Kevin Buettner
2003-02-20 23:19   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E54D379.3060900@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hunt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox