Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: David Carlton <carlton@math.stanford.edu>
Cc: gdb-patches@sources.redhat.com,
	Elena Zannoni <ezannoni@redhat.com>, Jim Blandy <jimb@redhat.com>
Subject: Re: [rfc] block.{h,c}
Date: Wed, 19 Feb 2003 12:52:00 -0000	[thread overview]
Message-ID: <3E537F1B.2010601@redhat.com> (raw)
In-Reply-To: <ro165rhqkjt.fsf@jackfruit.Stanford.EDU>

Can it eventually contain the few remaining scraps of block* code found 
in blockframe.c (hint, hint :-)?

> I'd like to move 'struct block' out of symtab.h into a new file
> block.h, and creating a new file block.c with block-specific
> functions.  Doing so would help lessen compilation dependencies, which
> is important for people like me with slow computers: right now
> symtab.h is included by around 140 files, while the resulting block.h
> would only be included by around 40 or so.  Basically, my code
> organization philosophy says that you should only define two different
> structures in the same include file if they are very closely linked
> (e.g. if code that refers one would almost always refer to the other);
> symtab.h doesn't pass that test.  For example, there's no particular
> reason why code using 'struct block' would be particluarly like to use
> 'struct minimal_symbol', or vice-versa.
> 
> I don't feel _too_ strongly about this; on the other hand, I can't see
> any reason not to make this change other than inertia.  (I guess that,
> the more include files there are, the more possibility there is that
> Makefile.in could get out of sync; that's not a good reason, though,
> and maybe the ARI could check for that?)

I think it is consistent with GDB's current overall direction - more 
modula with *.[hc] relating to specific objects or sets of objects.

Andrew


  reply	other threads:[~2003-02-19 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-18 22:41 David Carlton
2003-02-19 12:52 ` Andrew Cagney [this message]
2003-02-19 17:05   ` David Carlton
2003-02-19 21:21 ` Jim Blandy
2003-02-19 21:40   ` David Carlton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E537F1B.2010601@redhat.com \
    --to=ac131313@redhat.com \
    --cc=carlton@math.stanford.edu \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox