From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8393 invoked by alias); 19 Feb 2003 12:47:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8361 invoked from network); 19 Feb 2003 12:47:14 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 19 Feb 2003 12:47:14 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5227B2D37; Wed, 19 Feb 2003 07:52:00 -0500 (EST) Message-ID: <3E537DF0.50205@redhat.com> Date: Wed, 19 Feb 2003 12:47:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD i386; en-US; rv:1.0.2) Gecko/20030217 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: Re-initializing a list after the control returns to gdb... References: <20030219020101.GI2105@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00397.txt.bz2 > Hello, > > I am trying to do a small cleanup in our ada-tasks module, and I was > wondering if somebody could help me making sure I am using the right > approach. Joel, A more higher level question. What exactly is the story behind ada-task*. I glanced at the code and it looked very like a clone of the existing thread code. Andrew > Basically: the ada_language provides a set of commands, namely "info > tasks" and "task". Here is the syntax: > > - info tasks -> prints the list of tasks, equivalent of "info threads" > - info tasks -> the detailed information on a given task > - task -> print the current task id, equivalent of "thread" > - task -> switch to the given task > > The small annoyance I am trying to fix is that all these commands use > a list internally maintained in ada-tasks.c, which gets built only > when the "info tasks" command is called. So far, we have documented that > the above command may only be used after "info tasks" has been issued. > > What I am trying to do is to lift this limitation, by updating the > list of tasks every time the user has resumed the execution of the > inferior, just before the user gets back the prompt. > > I did it by inserting a call to ada_reset_tasks_list() inside > normal_stop(), like so: > > *************** print_stop_reason (enum inferior_stop_re > *** 3360,3365 **** > --- 3362,3369 ---- > void > normal_stop (void) > { > + ada_reset_tasks_list (NULL); > + > /* As with the notification of thread events, we want to delay > notifying the user that we've switched thread context until > the inferior actually stops. > > My testing shows that it seems to be working pretty well. But do you > think that this is a good idea? And does this change have any chance of > being accepted for inclusion (eventually, we are still ironing out some > wrinkles here and there to make our changes more acceptable, but hope to > be able to contribute our ada-language support changes soon)? > > -- Joel