From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32619 invoked by alias); 7 Feb 2003 21:59:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32612 invoked from network); 7 Feb 2003 21:59:32 -0000 Received: from unknown (HELO localhost.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 7 Feb 2003 21:59:32 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 875793CE5; Fri, 7 Feb 2003 16:59:32 -0500 (EST) Message-ID: <3E442C44.3020306@redhat.com> Date: Fri, 07 Feb 2003 21:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kris Warkentin Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: patch to add QNX NTO i386 support References: <1c3601c2cbc1$72eac3b0$0202040a@catdog> <3E40387D.50001@redhat.com> <008f01c2ce4b$427295f0$2a00a8c0@dash> <86lm0r3nha.fsf@elgar.kettenis.dyndns.org> <218c01c2cee4$8cde7610$0202040a@catdog> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00243.txt.bz2 > /* After a watchpoint trap, the PC points to the instruction after >> > the one that caused the trap. Therefore we don't need to step over > > it. > >> > But we do need to reset the status register to avoid another trap. > > */ > >> > #define HAVE_CONTINUABLE_WATCHPOINT > >> >> Hmm, this poses an interesting problem. The other i386 targets have >> this in their nm.h file, since they consider hardware watchpoints as a >> native-only feature. However, this isn't necessarily right since we >> might support hardware breakpoints via the remote protocol. If you >> can live with the native-only approach, please move this to your nm.h >> file. Otherwise we might need to multi-arch this definition. > > > Okay, file that under TODO along with the solib stuff. We have hardware > breakpoints on all our remote targets that support them. Just FYI, this needs to be added to the target vector (target.h) and not the architecture vector. For examples, see STOPPED_BY_WATCHPOINT et.al. A bit of manipulation of the existing nm-*.h files will be needed - have them define the value as 1. Can you please submit a separate patch that does just this. Andrew