From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21686 invoked by alias); 5 Feb 2003 02:59:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21642 invoked from network); 5 Feb 2003 02:59:53 -0000 Received: from unknown (HELO localhost.redhat.com) (205.151.15.183) by 172.16.49.205 with SMTP; 5 Feb 2003 02:59:53 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6424A3CB4; Tue, 4 Feb 2003 21:59:42 -0500 (EST) Message-ID: <3E407E1E.7060100@redhat.com> Date: Wed, 05 Feb 2003 02:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: Kris Warkentin , gdb-patches@sources.redhat.com Subject: Re: patch to add QNX NTO i386 support References: <1c3601c2cbc1$72eac3b0$0202040a@catdog> <3E40387D.50001@redhat.com> <006801c2ccb6$519f8c40$2a00a8c0@dash> <3E407997.1060700@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-02/txt/msg00163.txt.bz2 > Suggest separating the GDB stuff out (native, target, remote) and using > separate e-mail threads to discuss each. > > > I was going to but it's easier this way. > > It isn't for the person doing the review -> the easier the reviewer's life is, the quicker (well, ok, in theory :-/) the reviewer should be. I'd strongly focus on getting the cross debugger (--target=i386-unknown-nto) integrated into GDB, and then worry above the native. > >> The native nto-procfs.c makes use >> of some of the code in remote-qnx.c and remote-qnx-.c (we still have >> four more targets.) If you really feel it's necessary I could do the work >> but I had started on it and concluded it would either lead to a lot of >> duplicated code or an explosion of files. > > That looks like a design problem. The common code should likely be moved to something like nto-tdep.c. What exactly is common? Er, s/design/structural/ Andrew