From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-22166-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25585 invoked by alias); 1 Feb 2003 16:40:26 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25578 invoked from network); 1 Feb 2003 16:40:25 -0000
Received: from unknown (HELO localhost.redhat.com) (24.157.209.173)
  by 172.16.49.205 with SMTP; 1 Feb 2003 16:40:25 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 5A9333CB0; Sat,  1 Feb 2003 11:40:22 -0500 (EST)
Message-ID: <3E3BF876.3040506@redhat.com>
Date: Sat, 01 Feb 2003 16:40:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Testsuite: deal gracefully with lack of pthreads
References: <200302011624.h11GOTvb049469@elgar.kettenis.dyndns.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-02/txt/msg00024.txt.bz2

> This patch parallels what Daniel has done to the tests in the
> gdb.threads subdir.
> 
> Elana, Andrew, OK to check this in?

yes.

> There's probably one issue: We have a ChangeLog in both testsuite and
> testsuite/gdb.mi.  Both seem to be in used for MI tests.  Which one is
> preferred, and can we think of a way to avoid that both are used?

I don't know....  Probably (I'm not sure I should be saying this) merge 
gdb.mi/ChangeLog into ChangeLog.

File a bug report.

Andrew


> Mark
> 
> Index: ChangeLog
> from  Mark Kettenis  <kettenis@gnu.org>
> 
> 	* gdb669.exp, mi-pthreads.exp, mi1-pthreads.exp: Return instead of
> 	calling gdb_suppress_entire_file.
> 
> Index: gdb669.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/gdb669.exp,v
> retrieving revision 1.3
> diff -u -p -r1.3 gdb669.exp
> --- gdb669.exp 4 Jan 2003 15:37:40 -0000 1.3
> +++ gdb669.exp 1 Feb 2003 16:20:29 -0000
> @@ -179,10 +179,8 @@ set srcfile "$testfile.c"
>  set binfile "$objdir/$subdir/$testfile"
>  
>  set options [list debug incdir=$objdir]
> -if  {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options]
> -     != "" } {
> -  gdb_suppress_entire_file \
> -    "Testcase compile failed, so all tests in this file will automatically fail."
> +if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
> +    return -1
>  }
>  
>  mi_gdb_reinitialize_dir $srcdir/$subdir
> Index: mi-pthreads.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-pthreads.exp,v
> retrieving revision 1.5
> diff -u -p -r1.5 mi-pthreads.exp
> --- mi-pthreads.exp 7 Jan 2003 03:28:14 -0000 1.5
> +++ mi-pthreads.exp 1 Feb 2003 16:20:29 -0000
> @@ -208,10 +208,8 @@ set srcfile "$testfile.c"
>  set binfile "$objdir/$subdir/$testfile"
>  
>  set options [list debug incdir=$objdir]
> -if  {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options]
> -     != "" } {
> -  gdb_suppress_entire_file \
> -    "Testcase compile failed, so all tests in this file will automatically fail."
> +if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
> +    return -1
>  }
>  
>  mi_gdb_reinitialize_dir $srcdir/$subdir
> Index: mi1-pthreads.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi1-pthreads.exp,v
> retrieving revision 1.3
> diff -u -p -r1.3 mi1-pthreads.exp
> --- mi1-pthreads.exp 7 Jan 2003 03:28:14 -0000 1.3
> +++ mi1-pthreads.exp 1 Feb 2003 16:20:29 -0000
> @@ -208,10 +208,8 @@ set srcfile "$testfile.c"
>  set binfile "$objdir/$subdir/$testfile"
>  
>  set options [list debug incdir=$objdir]
> -if  {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options]
> -     != "" } {
> -  gdb_suppress_entire_file \
> -    "Testcase compile failed, so all tests in this file will automatically fail."
> +if {[gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
> +    return -1
>  }
>  
>  mi_gdb_reinitialize_dir $srcdir/$subdir
>