From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5638 invoked by alias); 28 Jan 2003 14:40:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5631 invoked from network); 28 Jan 2003 14:40:41 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by 172.16.49.205 with SMTP; 28 Jan 2003 14:40:41 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0313E3DD0; Tue, 28 Jan 2003 09:40:39 -0500 (EST) Message-ID: <3E369667.3060904@redhat.com> Date: Tue, 28 Jan 2003 14:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: HP/UX 64 need CALL_DUMMY_LOCATION ON_STACK? References: <3E2B59FE.8090401@redhat.com> <20030120030414.GK5477@gnat.com> <3E2B7A8E.6050403@redhat.com> <20030128041455.GG6437@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00759.txt.bz2 > I believe you are right. I did a bit of archeology, but could not > find the purpose of this undef. > > Before you added the '#define CALL_DUMMY_LOCATION ON_STACK' when you > changed the default value for CALL_DUMMY_LOCATION, there was no such > defined in tm-hppa.h... So the undef was useless, and now seems to > cause some breakage on hppa64. > > Short of understanding completely the issues at hand, I simply ran the > testsuite with and without the #undef, and found that that results are > sensibly better without (ie, to my relief, you guess right about hppa64). > > I have the following change ready: > > 2003-01-28 J. Brobecker > > * config/pa/tm-hppa64.h (CALL_DUMMY_LOCATION): Remove #undef > causing some regressions due to a change in the default value > for this macro. Thanks! Definitly check this in. Andrew