From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2858 invoked by alias); 28 Jan 2003 14:35:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2841 invoked from network); 28 Jan 2003 14:35:40 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by 172.16.49.205 with SMTP; 28 Jan 2003 14:35:40 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 34CC63DD0; Tue, 28 Jan 2003 09:35:33 -0500 (EST) Message-ID: <3E369535.5040100@redhat.com> Date: Tue, 28 Jan 2003 14:35:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, hunt@redhat.com Subject: Re: RFA: always default to using the libiberty regex References: <1043715417.1134.7.camel@Dragon> <20030128033359.GA11366@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00757.txt.bz2 > On Mon, Jan 27, 2003 at 04:56:56PM -0800, Martin M. Hunt wrote: > >> This patch deletes the configure code to check the OS implementation of >> regex and default to that. The default will now always be the builtin. >> >> >> 2003-01-27 Martin M. Hunt >> >> * configure.in: Revert check for system regex. Use builtin regex by >> default. >> * configure: Rebuilt. >> > > > I'm still not convinced this is a good idea. > > Context: it's a bug in the system's GNU C library, and should be fixed > as such. All the rest of us who have a version of glibc which has this > issue addressed don't have a problem, and I don't really want to carry > around yet another statically linked copy of regex if I don't need to. > Since it doesn't manifest on my system, I suspect it is fixed in glibc > 2.3.1; it's another piece of fallout from Red Hat's choice of using the > brand-new barely-tested glibc 2.2.93 for their desktop product. There are several choices here: - GDB prefers the installed regex. This is what the current config is doing. I think it is telling that the patch hasn't even been in for a month and, already, we've hit problems. No matter where the problem is, it is GDB that will get the blame. I also believe that way back when this was last debated, specific regex releases were identified as problematic. - GDB prefers the bundled regex. This is what the old config was doing. Doing this means that GDB needs to, at regular intervals, upgrade that code. We do this now for readline. It also means that the GDB developers are insulated from problems with the utility libraries. As best I can tell, the only people that really benefit from the system regex are those making distros - it saves them the hassle of having to remember --with-..regex=. GDB developers don't benefit - we all need to specify the bundled regex as otherwize we can't reproduce each others results (cf Martin's problem). GDB users don't benefit as they now get a GDB of unknown quality. Andrew -- Martin, I suspect that you are configuring with the wrong autoconf. You want the one on the sware binutils ftp site. Andrew