Re: ARM PATCH fix extract_return_value and store_return_value

Richard Earnshaw
2003-01-24T11:13:15Z

> > 2002-12-14 Richard Earnshaw <rearnsha@arm.com>
> >
> > * arm-tdep.c (convert_from_extended): New argument to hold the
> > type of floating point result we want to convert to. Make input
> > argument const. Fix all callers.
> > (convert_to_extended): Similarly.
> > (arm_extract_return_value): Now takes a regcache argument. Change
> > code to use regcache accessor functions. Correctly extract
> > smaller-than-word results on big-endian machines.
> > (arm_store_return_value): Now takes a regcache argument. Change
> > code to use regcache accessor functions. Correctly zero/sign extend
> > smaller than word results before storing into r0.
> > (arm_gdbarch_init): Register new-style extract_return_value and
> > store_return_value functions.
>
> Hi Richard,
>
> I can report that these
> changes do fix two fails for big-endian running callfuncs.exp.
> One of the fails was returning a one-byte struct, the other
> a two-byte struct. There were no other fails in callfuncs.exp.

Excellent. Thanks for doing the tests.

> As is, they conflict with some of Elena's
> vector changes, but I've massaged them into closer conformance
> with a more recent revision. Here's my merged patch (not entirely
> up to date, but more recent than what appears here).

I installed the patches to the public tree back in December, so these
conflicts must relate to some internal version you are testing on.

R.