From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4592 invoked by alias); 24 Jan 2003 19:45:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4583 invoked from network); 24 Jan 2003 19:45:07 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 24 Jan 2003 19:45:07 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h0OJG5f03858 for ; Fri, 24 Jan 2003 14:16:06 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h0OJj1n21513; Fri, 24 Jan 2003 14:45:03 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h0OJiwE09727; Fri, 24 Jan 2003 11:44:59 -0800 Message-ID: <3E3197BA.98F40D54@redhat.com> Date: Fri, 24 Jan 2003 19:45:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com CC: Richard.Earnshaw@buzzard.freeserve.co.uk, gdb-patches@sources.redhat.com, rearnsha@arm.com Subject: Re: ARM PATCH fix extract_return_value and store_return_value References: <200301241111.h0OBBxo13651@pc960.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00720.txt.bz2 Richard Earnshaw wrote: > > > > 2002-12-14 Richard Earnshaw > > > > > > * arm-tdep.c (convert_from_extended): New argument to hold the > > > type of floating point result we want to convert to. Make input > > > argument const. Fix all callers. > > > (convert_to_extended): Similarly. > > > (arm_extract_return_value): Now takes a regcache argument. Change > > > code to use regcache accessor functions. Correctly extract > > > smaller-than-word results on big-endian machines. > > > (arm_store_return_value): Now takes a regcache argument. Change > > > code to use regcache accessor functions. Correctly zero/sign extend > > > smaller than word results before storing into r0. > > > (arm_gdbarch_init): Register new-style extract_return_value and > > > store_return_value functions. > > > > Hi Richard, > > > > I can report that these > > changes do fix two fails for big-endian running callfuncs.exp. > > One of the fails was returning a one-byte struct, the other > > a two-byte struct. There were no other fails in callfuncs.exp. > > Excellent. Thanks for doing the tests. > > > As is, they conflict with some of Elena's > > vector changes, but I've massaged them into closer conformance > > with a more recent revision. Here's my merged patch (not entirely > > up to date, but more recent than what appears here). > > I installed the patches to the public tree back in December, so these > conflicts must relate to some internal version you are testing on. D'oh! You're right, I'm working with sources that we're just now getting ready to contribute. Well, we'll work out the conflicts then. Meantime, archaeological evidence indicates that we've covered the cases that were troubling me before, so I guess we can close this issue at least until Red Hat contributes the iMWXT port. Thanks so much for your help on this! Michael