From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21163 invoked by alias); 15 Jan 2003 14:22:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21156 invoked from network); 15 Jan 2003 14:22:11 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by 209.249.29.67 with SMTP; 15 Jan 2003 14:22:11 -0000 Received: from redhat.com (totem.toronto.redhat.com [172.16.14.242]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 0C2A1800086; Wed, 15 Jan 2003 09:22:00 -0500 (EST) Message-ID: <3E256E87.4010904@redhat.com> Date: Wed, 15 Jan 2003 14:22:00 -0000 From: Fernando Nasser Organization: Red Hat , Inc. - Toronto User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020827 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Carlton Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/testsuite] more selftest.exp tweaking References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00556.txt.bz2 David, it is approved but please change the comment to state which compiler version you've seem this order. Thanks, Fernando P.S.: What I am hoping is that one day in the future we can get rid of some cases for very old compilers. The comments will make it easier. This is not a serious enough condition for adding an 'if' on the compiler version, me thinks... -- Fernando Nasser Red Hat - Toronto E-Mail: David Carlton wrote:> I just noticed that my compiler (GCC 3.1 -O2) reorders some of the new > sysroot stuff in captured_main to a location where selftest.exp sees > it. I'm almost positive that seeing this is legitimate, not a bug in > GDB. > > Here's a patch to allow it; OK to commit? Tested on > i686-pc-linux-gnu/GCC 3.1 -O2/DWARF-2. > > (Selftest is a pain. Sigh.) > > David Carlton > carlton@math.stanford.edu > > 2003-01-14 David Carlton > > * gdb.base/selftest.exp (do_steps_and_nexts): Allow gdb_sysroot. > > Index: selftest.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/selftest.exp,v > retrieving revision 1.6 > diff -u -p -r1.6 selftest.exp > --- selftest.exp 23 Dec 2002 16:56:25 -0000 1.6 > +++ selftest.exp 14 Jan 2003 20:27:08 -0000 > @@ -170,6 +170,11 @@ proc do_steps_and_nexts {} { > set description "step over current_directory initialization" > set command "step" > } > + -re ".*gdb_sysroot = .*$gdb_prompt $" { > + # NOTE: carlton/2003-01-14: More optimization reordering. > + set description "step over gdb_sysroot initialization" > + set command "step" > + } > -re "\[ \t\]+\{\r\n$gdb_prompt $" { > setup_xfail "mips-*-irix5*" > fail "$description ended up at odd location" > @redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9