Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: RFC: Mostly kill FRAME_CHAIN_VALID, add user knob
Date: Fri, 10 Jan 2003 20:29:00 -0000	[thread overview]
Message-ID: <3E1F2D23.5080304@redhat.com> (raw)
In-Reply-To: <3E1F28BB.9080704@redhat.com>

>   /* If we're inside the entry file, it isn't valid.  */
>   /* NOTE/drow 2002-12-25: should there be a way to disable this check?  it assumes a single small entry file, and the way some debug readers (e.g. dbxread) figure out which object is the entry file is somewhat hokey.  */
>   if (inside_entry_file (frame_pc_unwind (fi)))
>     return 0;
> 
> Should this one be dropped?  If the user specified unwind past main, then they problably want _start() included in the backtrace.  It's presence also makes the other inside_entry_file() test redundant. 

Er, I think it should definitly be dropped.

The big outstanding problem I've had with the frame rewrite is with 
trying to re-order FRAME_CHAIN() and FRAME_SAVED_PC() (aka 
frame_pc_unwind) - the `unwind the pc first' code.  I found, for the 
PPC, that re-ordering things caused test regressions.

I think the above runs the exact same risks.  If not for the PPC, for 
some other target.  Besides, the other inside_entry_file (get_frame_pc 
(fi)) test makes it redundant.

enjoy,
Andrew



      reply	other threads:[~2003-01-10 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-26 12:20 Daniel Jacobowitz
2003-01-02 19:34 ` Andrew Cagney
2003-01-05  1:42   ` Daniel Jacobowitz
2003-01-05  1:44     ` Daniel Jacobowitz
2003-01-06 23:03     ` Andrew Cagney
2003-01-10 20:10 ` Andrew Cagney
2003-01-10 20:29   ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E1F2D23.5080304@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox