Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>, Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] lin-lwp.c prelim changes for new thread model
Date: Wed, 08 Jan 2003 00:34:00 -0000	[thread overview]
Message-ID: <3E1B71BC.8010009@redhat.com> (raw)
In-Reply-To: <20030107033133.GB5132@nevyn.them.org>


>> The minimal change I propose below is as follows:
>> When we send kill(SIGSTOP) to all the threads, we now include
>> the event thread, where previously we had made him a special case.
>> That way, whether in the new model or the old one, we can now do
>> a waitpid on every thread including the event thread.
>> 
>> What do you think?
> 
> 
> To be honest, I don't like this very much.  You're hurting performance
> in the current case (whose performance is already quite bad enough,
> thank you!).  I don't think that the additional complexity/waiting is
> worthwhile.

Just an aside,

At present GDB does ~60 system calls per multi-threaded single step (see 
previous discussion related to ptrace), these extra two calls may easily 
prove to be in the noise.  Given the thread has already stopped, they 
should be close to kernel no-ops.

When commenting on performance, the thing that is always needed is hard 
data either supporting or dismissing any claim.

Andrew



      parent reply	other threads:[~2003-01-08  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-06 23:44 Michael Snyder
2003-01-07  3:31 ` Daniel Jacobowitz
2003-01-07 20:39   ` Michael Snyder
2003-01-08  0:34   ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E1B71BC.8010009@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox