From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16350 invoked by alias); 7 Jan 2003 02:24:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16343 invoked from network); 7 Jan 2003 02:24:25 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by 209.249.29.67 with SMTP; 7 Jan 2003 02:24:25 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h071ucB05807 for ; Mon, 6 Jan 2003 20:56:39 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h072OCn28186; Mon, 6 Jan 2003 21:24:12 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h072OBn03907; Mon, 6 Jan 2003 18:24:11 -0800 Message-ID: <3E1A3A4B.6FB528CD@redhat.com> Date: Tue, 07 Jan 2003 02:24:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Christopher Faylor CC: gdb-patches@sources.redhat.com, RaoulGough@yahoo.co.uk Subject: Re: coffread.c extension for DLLs without debugging symbols References: <20030104044408.GA7364@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2003-01/txt/msg00259.txt.bz2 Christopher Faylor wrote: > > On Fri, Jan 03, 2003 at 07:39:31PM -0000, Raoul Gough wrote: > >Proposed ChangeLog entry, assuming the code is accepted: > > > >2003-01-03 Raoul Gough > > > > * coffread.c: Support non-debug export symbols for win32 DLLs > > WONDERFUL! I would love to have this code in the windows version of gdb. > I've often thought about doing something like this but I've never had > the stamina to look into what it would take to do this. > > I have a few comments. > > 0) The ChangeLog needs more information. Every new function should be > mentioned and changes to specific functions should be documented. > > 1) AFAICT, the formatting of the code looks great (a rarity for a first > timer) except for an odd comment or two which doesn't end in a "." as > required for a complete sentence. Yeah, yeah, a total nit but hey we've > got standards! > > 2) I wonder if this code should be ifdef'ed somehow for Windows since > it will add extra code for no gain on every COFF platform. Of course, > how many of those are there out there? Maybe this isn't a huge issue > after all. Geez, we include EVERY objfile reader on EVERY platform. Adding a little code to one vanishes into the noise! > > 3) objdump -p already has the ability to read and report on the export > table. I wonder if it would be useful (or possible) to generalize this > code so that gdb and objdump would be using the same base. I haven't > looked too closely but I think the code in question is in bfd/peicode.h. > Hmm. Maybe objdump isn't interested in the kinds of things that gdb > is, though, like what section a symbol is associated with... > > Anyway, I'll be giving this an actual test run in the next couple of > days. In the meantime, THANK YOU for doing this. Even given the very > minor above points, I think this will be a great boon for the Windows > version of gdb. This will help enormously in debugging on Windows. > > You will definitely need to get an assignment in to the FSF, though, > unfortunately. I think jimb at redhat dot com is the person to help > you with that. > > cgf > > P.S. Assuming that this works as advertised, I assume that you will > have no objections to my releasing a new version of gdb for windows > with this patch in it before the patch makes its way into the official > gdb repository, right? I think there are a few users in the cygwin > mailing list that would appreciate this change. > -- > Special for spam email harvesters: send email to aaaspam@sources.redhat.com > and be permanently blocked from mailing lists at sources.redhat.com.