From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32600 invoked by alias); 22 Dec 2002 11:03:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32592 invoked from network); 22 Dec 2002 11:03:14 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by 209.249.29.67 with SMTP; 22 Dec 2002 11:03:14 -0000 Received: from redhat.com (tooth.toronto.redhat.com [172.16.14.29]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 16D6980007F; Sun, 22 Dec 2002 06:03:03 -0500 (EST) Message-ID: <3E059F82.3040101@redhat.com> Date: Sun, 22 Dec 2002 03:04:00 -0000 From: Fernando Nasser Organization: Red Hat Canada User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020607 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: [Jim Blandy ] RFA: testsuite: pass optimization flag in the proper way References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00617.txt.bz2 > ! # Why do we need to specify '-O1' here? Shouldn't that sort of > ! # compilation parameter be under the control of the test framework > ! # (the target_list and so on)? Because you would be changing it for all tests while this test seems to require a specific setting.for some reason. This part is approved: > ! if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile" \ > ! executable {debug additional_flags=-w optimize=-O1}] != "" } { The comment could be: "Why do we need this specific optimization level here?" or the answer to this question if you know why. Sorry for the delay. Regards, Fernando Jim Blandy wrote: > Ping on this test suite patch. > > > > ------------------------------------------------------------------------ > > Subject: > RFA: testsuite: pass optimization flag in the proper way > From: > Jim Blandy > Date: > 18 Nov 2002 22:38:55 -0500 > To: > gdb-patches@sources.redhat.com > > > 2002-11-18 Jim Blandy > > * gdb.trace/tfind.exp: Pass '-O1' flag via the 'optimize' option, > rather than as part of the output file name. > > Index: gdb/testsuite/gdb.trace/tfind.exp > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.trace/tfind.exp,v > retrieving revision 1.2 > diff -c -r1.2 tfind.exp > *** gdb/testsuite/gdb.trace/tfind.exp 6 Mar 2001 08:22:00 -0000 1.2 > --- gdb/testsuite/gdb.trace/tfind.exp 19 Nov 2002 02:48:02 -0000 > *************** > *** 53,60 **** > set testfile "actions" > set srcfile ${testfile}.c > set binfile $objdir/$subdir/$testfile > ! if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile -O1" \ > ! executable {debug additional_flags=-w}] != "" } { > gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." > } > gdb_load $binfile > --- 53,64 ---- > set testfile "actions" > set srcfile ${testfile}.c > set binfile $objdir/$subdir/$testfile > ! > ! # Why do we need to specify '-O1' here? Shouldn't that sort of > ! # compilation parameter be under the control of the test framework > ! # (the target_list and so on)? > ! if { [gdb_compile "$srcdir/$subdir/$srcfile" "$binfile" \ > ! executable {debug additional_flags=-w optimize=-O1}] != "" } { > gdb_suppress_entire_file "Testcase compile failed, so all tests in this file will automatically fail." > } > gdb_load $binfile > > -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9