From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32634 invoked by alias); 23 Dec 2002 22:03:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32618 invoked from network); 23 Dec 2002 22:03:55 -0000 Received: from unknown (HELO localhost.redhat.com) (203.29.151.87) by sources.redhat.com with SMTP; 23 Dec 2002 22:03:55 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7B1263DCF; Fri, 20 Dec 2002 18:51:47 +0000 (GMT) Message-ID: <3E0366C3.10607@redhat.com> Date: Mon, 23 Dec 2002 14:50:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] exec.c: print_section_info() format string fixes References: <1021219190121.ZM13455@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00646.txt.bz2 > On 64-bit targets, I found that the values printed by print_section_info() > were not being printed in their entirety. I've just committed the patch > below to fix this problem. > > As I look at it now, I see that the FIXME comment can go. I'll zap it > in a moment. I don't think the problem is fixed, just improved. The 08l / 016l test assumes that the address is <= 64 bits. Hence, I think some sort of FIXME should remain (look for other similar cases). The bug database contains a suggestion that a new function - local_address_string_custom()(?) be added. > * exec.c (print_section_info): Select a format string to use with > local_hex_string_custom() based upon the value of TARGET_ADDR_BIT. > > printf_filtered (" @ %s", > - local_hex_string_custom ((unsigned long) p->the_bfd_section->filepos, "08l")); > + local_hex_string_custom (p->the_bfd_section->filepos, "08l")); BTW, Is the above correct? Andrew