From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12528 invoked by alias); 16 Dec 2002 21:07:39 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12518 invoked from network); 16 Dec 2002 21:07:37 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 16 Dec 2002 21:07:37 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id DDD40800075; Mon, 16 Dec 2002 16:07:35 -0500 (EST) Message-ID: <3DFE4097.10504@redhat.com> Date: Mon, 16 Dec 2002 16:40:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: Recent MI patches broke the testsuite References: <20021215211132.GA31984@nevyn.them.org> <3DFE15BA.4080207@redhat.com> <15870.6748.994104.390618@localhost.redhat.com> <20021216182341.GA22508@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00504.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Dec 16, 2002 at 01:24:28PM -0500, Elena Zannoni wrote: > >>J. Johnston writes: >> > My bad. :( The new mi-basics.exp testcase is my usual sanity test >> > for this change. It was updated and in fact works fine as it is expecting >> > the new behavior. >> > >> > I did not look at the correct gdb.log for the full mi testsuite. >> > As you have noted, the lib/mi-support.exp routine mi_reinitialize_dir >> > is using -environment-directory and is expecting the old output. >> > >> > I have a patch for lib/mi=support.exp to handle the new syntax which I have >> > included. Since I require approval for patches I will revert the >> > original patch and resubmit with the added change unless Elena says >> > otherwise. >> > >> >>If this patch fixes the testsuite, no need to revert the other one, >>just check this in. Don't forget the ChangeLog. >> >>Maybe Daniel can verify that it fixes his problem? > > > Yes, it does, except for the mi-basics.exp part. And that's minor. > Great. I have checked in the patch from the previous note. I will look into making the mi-basics.exp test more robust with regards to relative paths without overly abusing .*. -- Jeff J.