From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11518 invoked by alias); 16 Dec 2002 16:46:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11472 invoked from network); 16 Dec 2002 16:46:50 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 16 Dec 2002 16:46:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E7A293CBB; Mon, 16 Dec 2002 11:46:48 -0500 (EST) Message-ID: <3DFE0378.7080902@redhat.com> Date: Mon, 16 Dec 2002 08:56:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] improved error message References: <200212132326.gBDNQdAm009198@to-limbo.toronto.redhat.com> <3DFDFE7C.3060100@redhat.com> <20021216163625.GB16417@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00475.txt.bz2 > On Mon, Dec 16, 2002 at 11:25:32AM -0500, Andrew Cagney wrote: > >> >There are like five places in thread-db.c that all give the same >> >error message. This just adds the function name, so you have a >> >chance of figuring out where the error occurred. >> > >> >2002-12-13 Michael Snyder >> > >> > * thread-db.c (thread_from_lwp): Uniquify error msg. >> > (lwp_from_thread): Ditto. >> > (check_event): Ditto. >> > (find_new_threads_callback): Ditto. >> > (thread_db_pid_to_str): Ditto. > >> >> Er, this looks wrong. A normal user visible error message should not >> include references to internal function names. Can you either reword >> the messages or, perhaphs, add a debug mode that displys this additional >> information? > > > These are essentially internal error messages - none of them should > ever happen. They do now, of course. > > IMVHO I like Michael's change; now when people report these error > messages I'll know automatically which one they are. They tend to be > only spontaneously reproducible. If it is a internal error, call internal_error(). Andrew