From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23084 invoked by alias); 13 Dec 2002 21:49:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23037 invoked from network); 13 Dec 2002 21:49:50 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 13 Dec 2002 21:49:50 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E2FB53CE3; Fri, 13 Dec 2002 16:49:03 -0500 (EST) Message-ID: <3DFA55CF.4050203@redhat.com> Date: Fri, 13 Dec 2002 13:59:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Replace complain() with complaint() References: <1021212043633.ZM12225@localhost.localdomain> <3DFA412D.4030409@redhat.com> <1021213203820.ZM21776@localhost.localdomain> <1021213211537.ZM13136@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00438.txt.bz2 > Okay, now I see a -Wformat warning. Fortunately, buildsym.c was the only > file affected. Below are the diffs that I propose using for that file. > (These take the place of the buildsym.c diffs that I previously posted.) > The ChangeLog entries remain the same. Ok. Out of interest, how many other problems did the first pass find? > Note the use of paddr_nz() to convert the CORE_ADDR to a string. According > to defs.h, this most closely corresponds to the %lx format. Also, the > paddr() family of functions have an advantage over local_hex_string_custom() > (and the like) in that it's safe to use several of these calls together > without having to worry about the internal storage being overwritten. Hmm, bug report! Things to do includes the addition of a local_address_string_custom() method that does in a language dependant way the display of an address. This problem with buffers should be fixed then. Andrew