Re: gdb patch to suppress empty lines, re-visited

Daniel Jacobowitz
2002-12-11T23:50:16Z

On Wed, Dec 11, 2002 at 03:27:59PM -0800, Michael Snyder wrote:
> Per Bothner wrote:
> >
> > This is a revision of a patch originally from 1999:
> > http://sources.redhat.com/ml/gdb-patches/1999-q2/msg00093.html
> >
> > I'm not sure if the patch in top.c does anything, since I don't
> > know when/if readline is called from command_line_input.
> >
> > OK to check in? With or without the top.c change?
> > --
> > --Per Bothner
>
> For posterity, this changes the console output when you are
> repeating a command a bunch of times by hitting return.
> It changes, eg.
> 1038 <main+8>: call 0x138818 <get_run_time>
> (gdb)
> 0xe103c <main+12>: st %i1, [ %fp + 0x48 ]
> (gdb)
> 0xe1040 <main+16>: st %o0, [ %fp + -464 ]
> (gdb)
>
> to
>
> (gdb) x/i $pc
> 0xe1038 <main+8>: call 0x138818 <get_run_time>
> 0xe103c <main+12>: st %i1, [ %fp + 0x48 ]
> 0xe1040 <main+16>: st %o0, [ %fp + -464 ]
> (gdb)
>
> Per, I think the first discussion needs to be,
> do we agree that we want this change? This changes
> visible behavior, quite broadly.

I'll put in my vote for "yes, or at least as an option".

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer