From: Andrew Cagney <ac131313@redhat.com>
To: Jim Blandy <jimb@redhat.com>
Cc: Michael Snyder <msnyder@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa/breakpoint] Use a frame ID instead of a frame
Date: Wed, 11 Dec 2002 13:46:00 -0000 [thread overview]
Message-ID: <3DF7B152.1040106@redhat.com> (raw)
In-Reply-To: <vt2lm2w6zds.fsf@zenia.red-bean.com>
> Andrew Cagney <ac131313@redhat.com> writes:
>
>> Ok to commit?
>
>
> Yes, it looks good to me.
Thanks!
> I can't try it out, since it doesn't apply any more (I guess that's
> what happens if you take too long to review something), but it seems
> to me that it should have no effect on the behavior of the code at
> all, since frame_id_eq actually ignores the PCs of the frame_ids it's
> passed, so frame_id's behave just like the frame base addresses the
> code used before. Is that right?
Yes, that is correct. The code in frame_id_eq() is intentionally
missing (I've tried adding it but it has zero effect on the i386 test
results -> need more tests :-().
Andrew
prev parent reply other threads:[~2002-12-11 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-03 18:54 Andrew Cagney
2002-12-10 13:20 ` Andrew Cagney
2002-12-11 13:27 ` Jim Blandy
2002-12-11 13:46 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3DF7B152.1040106@redhat.com \
--to=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox