Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Unwind the PC first when creating a frame
Date: Wed, 11 Dec 2002 13:42:00 -0000	[thread overview]
Message-ID: <3DF7ADAC.7060706@redhat.com> (raw)
In-Reply-To: <3DF6A627.9060700@redhat.com>

> Hello,
> 
> This patch changes the frame creation code so that it can unwind the PC before doing anything else.  By unwinding the PC first, it becomes possible to correctly set the frame from the outset.  The old code would set the frame's type last (resulting in architecture code having to back patch it).   It also (at least in theory) makes it possible to avoid certain frame unwinds.
> 
> Since, right now, all architectures currently specify a deprecated init frame pc method, the code isn't used by any architecture.  A follow on will be to enable the code on at least one architecture.
> 
> I'll commit the attached in a few days,
> enjoy,
> 
> Andrew
> 
> 
> 
> 2002-12-10  Andrew Cagney  <ac131313@redhat.com>
> 
> 	* frame.c (frame_type_from_pc): New function.
> 	(create_new_frame): Use frame_type_from_pc instead of custom code.
> 	(get_prev_frame): When neither DEPRECATED_INIT_FRAME_PC_P nor
> 	DEPRECATED_INIT_FRAME_PC_FIRST_P use frame_type_from_pc and
> 	frame_pc_unwind to set the frame's type at the point of frame
> 	creation.

Hmm, I'm going to put this patch on hold until after the 
frame_id_unwind() patch I just posted is committed. That way the switch 
to use frame_id_unwind() and frame_pc_unwind() can be done in a single hit.

Andrew



      reply	other threads:[~2002-12-11 21:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-10 20:27 Andrew Cagney
2002-12-11 13:42 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DF7ADAC.7060706@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox