From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-20883-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 30773 invoked by alias); 11 Dec 2002 21:24:44 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30765 invoked from network); 11 Dec 2002 21:24:43 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 11 Dec 2002 21:24:43 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id CD3873C17; Wed, 11 Dec 2002 16:24:37 -0500 (EST)
Message-ID: <3DF7AD15.9020700@redhat.com>
Date: Wed, 11 Dec 2002 13:24:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.1) Gecko/20021211
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc]  Add get_frame_saved_regs() and get_frame_saved_regs_p()
References: <3DF7A7C9.9040306@redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-12/txt/msg00371.txt.bz2

> +CORE_ADDR *
> +get_frame_saved_regs (struct frame_info *fi)
> +{
> +  if (fi->saved_regs != NULL)

Oops!  Try:

	if (fi->saved_regs == NULL)

The scary thing is that, on i386, it only triggered 7 failures :-?

> +    {
> +      fi->saved_regs = frame_obstack_alloc (SIZEOF_FRAME_SAVED_REGS);
> +      memset (fi->saved_regs, 0, SIZEOF_FRAME_SAVED_REGS);
> +    }
> +  return fi->saved_regs;
> +}

Andrew