From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1493 invoked by alias); 1 Dec 2002 19:51:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1486 invoked from network); 1 Dec 2002 19:51:49 -0000 Received: from unknown (HELO localhost.redhat.com) (24.114.171.218) by sources.redhat.com with SMTP; 1 Dec 2002 19:51:49 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7AD073F30; Sun, 1 Dec 2002 14:51:40 -0500 (EST) Message-ID: <3DEA684C.90409@redhat.com> Date: Sun, 01 Dec 2002 11:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] New method find_frame_sal() References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-12/txt/msg00004.txt.bz2 > On Thu, 28 Nov 2002, Andrew Cagney wrote: > > >> While cleaning up accesses to the `struct frame_info', I kept coming >> across code snippits like: >> >> sal = find_pc_line (fi->pc, >> (fi->next != (struct frame_info *) NULL >> && !(get_frame_type (fi->next) == SIGTRAMP_FRAME) >> && !(get_frame_type (fi->next) == DUMMY_FRAME))); >> >> (Originally it was worse, as there was also fi->signal_handler_caller >> and PC_IN_CALL_DUMMY (fi->pc, fi->frame, fi->frame).) >> >> The attached patch adds the function: >> >> find_frame_sal(fi, &sal); >> >> that encapsulates all of the above. > > > Should this method be documented in gdbint.texinfo perhaps? Um, to this level of detail, I don't think so. The thing I think is missing is a `Frames' chapter which describes how things hang together. Guess why I've not got back to you with that frames doco patch I posted .... Andrew