From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15005 invoked by alias); 27 Nov 2002 18:55:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14996 invoked from network); 27 Nov 2002 18:55:01 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 27 Nov 2002 18:55:01 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id CA3103FE8; Wed, 27 Nov 2002 13:54:57 -0500 (EST) Message-ID: <3DE51501.3000504@redhat.com> Date: Wed, 27 Nov 2002 10:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com, fnasser@redhat.com Subject: Re: [RFA/testsuite] Handle MIPS in step-test.exp References: <20021022020218.GA22839@nevyn.them.org> <3DB55E72.3060700@redhat.com> <20021022142537.GA16933@nevyn.them.org> Content-Type: multipart/mixed; boundary="------------070801000504070001020908" X-SW-Source: 2002-11/txt/msg00686.txt.bz2 This is a multi-part message in MIME format. --------------070801000504070001020908 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 562 > On Tue, Oct 22, 2002 at 10:19:30AM -0400, Andrew Cagney wrote: > >> >The MIPS PIC calling conventions have a $gp register which needs to be >> >reloaded after function calls, so they need the same treatment IA-64 and PA >> >do in step-test. I also needed to finish stepping past one call before >> >looking for the next or the test showed a bogus failure. > >> >> Is this a straight GDB bug? > > > It's a straight testsuite bug. The test is full of assumptions about > when nexti will move to the next source line. Ah, m'kay by me. Fernando? Andrew --------------070801000504070001020908 Content-Type: message/rfc822; name="mailbox-message://ac131313@movemail/fsf/gdb/patches#3835101" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="mailbox-message://ac131313@movemail/fsf/gdb/patches#3835101" Content-length: 4765 X-Mozilla-Status2: 00000000 Return-Path: Delivered-To: ac131313@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id A67F73EF4 for ; Tue, 22 Oct 2002 10:00:25 -0400 (EDT) Envelope-to: cagney@gnu.org Delivery-date: Mon, 21 Oct 2002 22:02:38 -0400 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-5.9.13) for ac131313@localhost (single-drop); Tue, 22 Oct 2002 10:00:25 -0400 (EDT) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.10) id 183oNS-00084D-00 for cagney@gnu.org; Mon, 21 Oct 2002 22:02:38 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 183oMt-0004I1-00 for cagney@gnu.org; Mon, 21 Oct 2002 22:02:04 -0400 Received: from sources.redhat.com ([209.249.29.67]) by monty-python.gnu.org with smtp (Exim 4.10) id 183oMt-0004Hu-00 for cagney@gnu.org; Mon, 21 Oct 2002 22:02:03 -0400 Received: (qmail 26115 invoked by alias); 22 Oct 2002 02:02:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com Received: (qmail 26107 invoked from network); 22 Oct 2002 02:02:00 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 22 Oct 2002 02:02:00 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 183pIV-0003fv-00; Mon, 21 Oct 2002 22:01:36 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 183oN8-0005xL-00; Mon, 21 Oct 2002 22:02:18 -0400 Date: Mon, 21 Oct 2002 22:02:18 -0400 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Cc: fnasser@redhat.com Subject: [RFA/testsuite] Handle MIPS in step-test.exp Message-ID: <20021022020218.GA22839@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com, fnasser@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.1i X-Spam-Status: No, hits=-4.6 required=5.0 tests=SPAM_PHRASE_00_01,USER_AGENT,USER_AGENT_MUTT version=2.41 X-Spam-Level: Content-length: 2069 The MIPS PIC calling conventions have a $gp register which needs to be reloaded after function calls, so they need the same treatment IA-64 and PA do in step-test. I also needed to finish stepping past one call before looking for the next or the test showed a bogus failure. Is this OK? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer 2002-10-21 Daniel Jacobowitz * gdb.base/step-test.exp: Allow MIPS to return to the line of a function call. Index: testsuite/gdb.base/step-test.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/step-test.exp,v retrieving revision 1.5 diff -u -p -r1.5 step-test.exp --- testsuite/gdb.base/step-test.exp 5 Apr 2002 00:30:09 -0000 1.5 +++ testsuite/gdb.base/step-test.exp 13 Oct 2002 22:55:02 -0000 @@ -78,7 +78,8 @@ gdb_test "step" ".*${decimal}.*myglob.*" # On PA64, we end up at a different instruction than PA32. # On IA-64, we also end up on callee instead of on the next line due # to the restoration of the global pointer (which is a caller-save). -if { [istarget "hppa2.0w-hp-hpux*"] || [istarget "ia64-*-*"]} { +# Similarly on MIPS PIC targets. +if { [istarget "hppa2.0w-hp-hpux*"] || [istarget "ia64-*-*"] || [istarget "mips*-*-*"]} { send_gdb "finish\n" gdb_expect { -re ".*${decimal}.*a.*5.*= a.*3.*$gdb_prompt $" { pass "step out 1" } @@ -176,8 +177,11 @@ gdb_expect { # On PA64, we end up at a different instruction than PA32. # On IA-64, we end up on callee instead of on the following line due # to the restoration of the global pointer. - if { [istarget "hppa2.0w-hp-hpux*"] || [istarget "ia64-*-*"] } { + # Similarly on MIPS PIC targets. + if { [istarget "hppa2.0w-hp-hpux*"] || [istarget "ia64-*-*"] || [istarget "mips*-*-*"] } { pass "stepi: finish call 2" + test_i "stepi: past call" "stepi" \ + ".*${decimal}.*callee.*STEPI" ".*${decimal}.*callee.*NEXTI" } else { fail "stepi: finish call 2" return --------------070801000504070001020908--