From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6002 invoked by alias); 16 Nov 2002 00:58:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5988 invoked from network); 16 Nov 2002 00:58:31 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 16 Nov 2002 00:58:31 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id F3E353E4B; Fri, 15 Nov 2002 19:58:30 -0500 (EST) Message-ID: <3DD59836.7080700@redhat.com> Date: Fri, 15 Nov 2002 16:58:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [patch] Make generic_unwind_get_saved_register() static References: <3DD58C2E.7000906@redhat.com> Content-Type: multipart/mixed; boundary="------------070207020906010805060902" X-SW-Source: 2002-11/txt/msg00437.txt.bz2 This is a multi-part message in MIME format. --------------070207020906010805060902 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 375 > Hello, > > Another "frame.h" interface removed. If get_saved_register() isn't specified, the code calls generic_unwind_get_saved_register() so there is little point in setting it explicitly. > > I'll commit once my all architectures build finishes. Good thing to. Attached is what I finally committed. Missed the mn10200 target :-/ Andrew > Also tested on i386. --------------070207020906010805060902 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 9720 2002-11-15 Andrew Cagney * frame.c (generic_unwind_get_saved_register): Make static. * frame.h (generic_unwind_get_saved_register): Delete declaration. * avr-tdep.c (avr_gdbarch_init): Do not set get_saved_register, defaults to generic_unwind_get_saved_register. * mn10300-tdep.c (mn10300_gdbarch_init): Ditto. * h8300-tdep.c (h8300_gdbarch_init): Ditto. * frv-tdep.c (frv_gdbarch_init): Ditto. * i386-tdep.c (i386_gdbarch_init): Ditto. * s390-tdep.c (s390_gdbarch_init): Ditto. * rs6000-tdep.c (rs6000_gdbarch_init): Ditto. * v850-tdep.c (v850_gdbarch_init): Ditto. * mcore-tdep.c (mcore_gdbarch_init): Ditto. * d10v-tdep.c (d10v_gdbarch_init): Ditto. * config/mn10200/tm-mn10200.h (GET_SAVED_REGISTER): Delete macro. Index: avr-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/avr-tdep.c,v retrieving revision 1.10 diff -u -r1.10 avr-tdep.c --- avr-tdep.c 17 Sep 2002 23:08:45 -0000 1.10 +++ avr-tdep.c 16 Nov 2002 00:55:51 -0000 @@ -1215,8 +1215,6 @@ set_gdbarch_max_register_virtual_size (gdbarch, 4); set_gdbarch_register_virtual_type (gdbarch, avr_register_virtual_type); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); - set_gdbarch_print_insn (gdbarch, print_insn_avr); set_gdbarch_use_generic_dummy_frames (gdbarch, 1); Index: d10v-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/d10v-tdep.c,v retrieving revision 1.54 diff -u -r1.54 d10v-tdep.c --- d10v-tdep.c 14 Nov 2002 00:25:02 -0000 1.54 +++ d10v-tdep.c 16 Nov 2002 00:55:52 -0000 @@ -1604,7 +1604,6 @@ set_gdbarch_sizeof_call_dummy_words (gdbarch, sizeof (d10v_call_dummy_words)); set_gdbarch_call_dummy_p (gdbarch, 1); set_gdbarch_call_dummy_stack_adjust_p (gdbarch, 0); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); set_gdbarch_fix_call_dummy (gdbarch, generic_fix_call_dummy); set_gdbarch_deprecated_extract_return_value (gdbarch, d10v_extract_return_value); Index: frame.c =================================================================== RCS file: /cvs/src/src/gdb/frame.c,v retrieving revision 1.26 diff -u -r1.26 frame.c --- frame.c 15 Nov 2002 22:16:25 -0000 1.26 +++ frame.c 16 Nov 2002 00:55:52 -0000 @@ -261,7 +261,7 @@ frame_unwind_signed_register (get_next_frame (frame), regnum, val); } -void +static void generic_unwind_get_saved_register (char *raw_buffer, int *optimizedp, CORE_ADDR *addrp, Index: frame.h =================================================================== RCS file: /cvs/src/src/gdb/frame.h,v retrieving revision 1.33 diff -u -r1.33 frame.h --- frame.h 15 Nov 2002 23:24:21 -0000 1.33 +++ frame.h 16 Nov 2002 00:55:52 -0000 @@ -424,13 +424,6 @@ struct frame_info *, int, enum lval_type *); -extern void generic_unwind_get_saved_register (char *raw_buffer, - int *optimized, - CORE_ADDR * addrp, - struct frame_info *frame, - int regnum, - enum lval_type *lval); - extern void generic_save_call_dummy_addr (CORE_ADDR lo, CORE_ADDR hi); extern void get_saved_register (char *raw_buffer, int *optimized, Index: frv-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/frv-tdep.c,v retrieving revision 1.5 diff -u -r1.5 frv-tdep.c --- frv-tdep.c 14 Nov 2002 00:25:02 -0000 1.5 +++ frv-tdep.c 16 Nov 2002 00:55:53 -0000 @@ -1126,8 +1126,6 @@ set_gdbarch_push_dummy_frame (gdbarch, generic_push_dummy_frame); set_gdbarch_fix_call_dummy (gdbarch, generic_fix_call_dummy); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); - set_gdbarch_decr_pc_after_break (gdbarch, 0); set_gdbarch_function_start_offset (gdbarch, 0); set_gdbarch_register_convertible (gdbarch, generic_register_convertible_not); Index: h8300-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/h8300-tdep.c,v retrieving revision 1.23 diff -u -r1.23 h8300-tdep.c --- h8300-tdep.c 31 Oct 2002 20:22:45 -0000 1.23 +++ h8300-tdep.c 16 Nov 2002 00:55:53 -0000 @@ -1106,7 +1106,6 @@ set_gdbarch_init_extra_frame_info (gdbarch, h8300_init_extra_frame_info); set_gdbarch_frame_init_saved_regs (gdbarch, h8300_frame_init_saved_regs); set_gdbarch_frame_chain (gdbarch, h8300_frame_chain); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); set_gdbarch_saved_pc_after_call (gdbarch, h8300_saved_pc_after_call); set_gdbarch_frame_saved_pc (gdbarch, h8300_frame_saved_pc); set_gdbarch_skip_prologue (gdbarch, h8300_skip_prologue); Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.94 diff -u -r1.94 i386-tdep.c --- i386-tdep.c 8 Nov 2002 23:59:58 -0000 1.94 +++ i386-tdep.c 16 Nov 2002 00:55:54 -0000 @@ -1598,8 +1598,6 @@ i386_register_convert_to_virtual); set_gdbarch_register_convert_to_raw (gdbarch, i386_register_convert_to_raw); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); - set_gdbarch_pc_in_call_dummy (gdbarch, pc_in_call_dummy_at_entry_point); /* "An argument's size is increased, if necessary, to make it a Index: mcore-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mcore-tdep.c,v retrieving revision 1.22 diff -u -r1.22 mcore-tdep.c --- mcore-tdep.c 14 Nov 2002 00:25:03 -0000 1.22 +++ mcore-tdep.c 16 Nov 2002 00:55:54 -0000 @@ -1100,7 +1100,6 @@ set_gdbarch_pc_regnum (gdbarch, 64); set_gdbarch_sp_regnum (gdbarch, 0); set_gdbarch_fp_regnum (gdbarch, 0); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); /* Call Dummies: */ Index: mn10300-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mn10300-tdep.c,v retrieving revision 1.33 diff -u -r1.33 mn10300-tdep.c --- mn10300-tdep.c 14 Nov 2002 00:25:03 -0000 1.33 +++ mn10300-tdep.c 16 Nov 2002 00:55:55 -0000 @@ -1162,7 +1162,6 @@ set_gdbarch_decr_pc_after_break (gdbarch, 0); /* Stack unwinding. */ - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); set_gdbarch_frame_chain_valid (gdbarch, generic_file_frame_chain_valid); set_gdbarch_inner_than (gdbarch, core_addr_lessthan); set_gdbarch_frame_chain_valid (gdbarch, generic_file_frame_chain_valid); Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.91 diff -u -r1.91 rs6000-tdep.c --- rs6000-tdep.c 14 Nov 2002 20:37:29 -0000 1.91 +++ rs6000-tdep.c 16 Nov 2002 00:55:56 -0000 @@ -2890,7 +2890,6 @@ set_gdbarch_pc_in_call_dummy (gdbarch, generic_pc_in_call_dummy); set_gdbarch_call_dummy_p (gdbarch, 1); set_gdbarch_call_dummy_stack_adjust_p (gdbarch, 0); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); set_gdbarch_fix_call_dummy (gdbarch, rs6000_fix_call_dummy); set_gdbarch_frame_align (gdbarch, rs6000_frame_align); set_gdbarch_push_dummy_frame (gdbarch, generic_push_dummy_frame); Index: s390-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/s390-tdep.c,v retrieving revision 1.54 diff -u -r1.54 s390-tdep.c --- s390-tdep.c 14 Nov 2002 00:25:03 -0000 1.54 +++ s390-tdep.c 16 Nov 2002 00:55:56 -0000 @@ -1811,7 +1811,6 @@ set_gdbarch_num_regs (gdbarch, S390_NUM_REGS); set_gdbarch_cannot_fetch_register (gdbarch, s390_cannot_fetch_register); set_gdbarch_cannot_store_register (gdbarch, s390_cannot_fetch_register); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); set_gdbarch_use_struct_convention (gdbarch, s390_use_struct_convention); set_gdbarch_frame_chain_valid (gdbarch, func_frame_chain_valid); set_gdbarch_register_name (gdbarch, s390_register_name); Index: v850-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/v850-tdep.c,v retrieving revision 1.24 diff -u -r1.24 v850-tdep.c --- v850-tdep.c 14 Nov 2002 00:25:03 -0000 1.24 +++ v850-tdep.c 16 Nov 2002 00:55:57 -0000 @@ -1233,7 +1233,6 @@ set_gdbarch_init_extra_frame_info (gdbarch, v850_init_extra_frame_info); set_gdbarch_frame_init_saved_regs (gdbarch, v850_frame_init_saved_regs); set_gdbarch_frame_chain (gdbarch, v850_frame_chain); - set_gdbarch_get_saved_register (gdbarch, generic_unwind_get_saved_register); set_gdbarch_saved_pc_after_call (gdbarch, v850_saved_pc_after_call); set_gdbarch_frame_saved_pc (gdbarch, v850_frame_saved_pc); set_gdbarch_skip_prologue (gdbarch, v850_skip_prologue); Index: config/mn10200/tm-mn10200.h =================================================================== RCS file: /cvs/src/src/gdb/config/mn10200/tm-mn10200.h,v retrieving revision 1.13 diff -u -r1.13 tm-mn10200.h --- config/mn10200/tm-mn10200.h 14 Nov 2002 00:25:04 -0000 1.13 +++ config/mn10200/tm-mn10200.h 16 Nov 2002 00:55:57 -0000 @@ -210,10 +210,5 @@ extern use_struct_convention_fn mn10200_use_struct_convention; #define USE_STRUCT_CONVENTION(GCC_P, TYPE) mn10200_use_struct_convention (GCC_P, TYPE) -/* Override the default get_saved_register function with - one that takes account of generic CALL_DUMMY frames. */ -#define GET_SAVED_REGISTER(raw_buffer, optimized, addrp, frame, regnum, lval) \ - generic_unwind_get_saved_register (raw_buffer, optimized, addrp, frame, regnum, lval) - /* Define this for Wingdb */ #define TARGET_MN10200 --------------070207020906010805060902--