Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Correct pascal parser problem.
Date: Wed, 13 Nov 2002 07:23:00 -0000	[thread overview]
Message-ID: <3DD26E76.2070607@redhat.com> (raw)
In-Reply-To: <5.0.2.1.2.20021113101533.00b01c48@ics.u-strasbg.fr>

> At 10:12 13/11/2002, you wrote:
> 
> 
>>  The following patch fixes a problem when parsing 
>>expressions that started with fields of this.
>>
>>  If you where in a method that have a filed named owner
>>that is a pointer,
>>(gdb) p owner
>>$1 = (PSYMTABLE) $507a48
>>(gdb) p owner^
>>Type TNAMEDINDEXOBJECT has no component named OWNER^.
>>
>>The problem was that lookup_struct_elt_type
>>was call with 'OWNER^' instead of only 'OWNER'.
>>
>>After that patch, I get this:
>>(gdb) p owner
>>$3 = (PSYMTABLE) $507a48
>>(gdb) p owner^
>>$4 = {NAME = $0, DATASIZE = 0, DATAALIGNMENT = 2, SYMINDEX = $507a78,
>>  DEFINDEX = $507a98, SYMSEARCH = $507ab8, NEXT = $5075f8, DEFOWNER = $507ad8,
>>  ADDRESS_FIXUP = 0, UNITID = 0, SYMTABLELEVEL = 0,
>>  SYMTABLETYPE = RECORDSYMTABLE, _vptr$ = {$4eb2c8, $1}}
>>which is much better.
> 
> 
> Can I also commit this to 5.3 branch or is it too late?

No, it isn't too late.  Still plenty of HIGH priority bug reports (where 
GDB doesn't build :-( ).

Andrew


>>ChangeLog entry:
>>
>>2002-11-13  Pierre Muller  <muller@ics.u-strasbg.fr>
>>
>>       * p-exp.y (name_not_typename): Use copy_name to
>>       set current_type variable for fields of THIS.
>>
>>
>>
>>diff -u -p -r1.17 p-exp.y
>>--- p-exp.y     6 Nov 2002 22:48:25 -0000       1.17
>>+++ p-exp.y     13 Nov 2002 09:04:25 -0000
>>@@ -649,7 +649,7 @@ variable:   name_not_typename
>>                              if (this_type)
>>                                current_type = lookup_struct_elt_type (
>>                                  this_type,
>>-                                 $1.stoken.ptr, false);
>>+                                 copy_name($1.stoken), false);
>>                              else
>>                                current_type = NULL;
>>                            }
>>
>>
>>
>>
>>Pierre Muller
>>Institut Charles Sadron
>>6,rue Boussingault
>>F 67083 STRASBOURG CEDEX (France)
>>mailto:muller@ics.u-strasbg.fr
>>Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
> 
> 
> 
> 
> Pierre Muller
> Institut Charles Sadron
> 6,rue Boussingault
> F 67083 STRASBOURG CEDEX (France)
> mailto:muller@ics.u-strasbg.fr
> Phone : (33)-3-88-41-40-07  Fax : (33)-3-88-41-40-99
> 
> 



  reply	other threads:[~2002-11-13 15:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-13  1:13 Pierre Muller
2002-11-13  1:17 ` Pierre Muller
2002-11-13  7:23   ` Andrew Cagney [this message]
2002-11-13  7:45     ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DD26E76.2070607@redhat.com \
    --to=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox