From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9518 invoked by alias); 12 Nov 2002 15:58:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9500 invoked from network); 12 Nov 2002 15:58:01 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 12 Nov 2002 15:58:01 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7D7883CCE; Tue, 12 Nov 2002 10:58:01 -0500 (EST) Message-ID: <3DD12509.4090003@redhat.com> Date: Tue, 12 Nov 2002 07:58:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "J. Johnston" Cc: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: RFA: gdb/783 doc change References: <3DD03C0D.7A22A286@redhat.com> <15824.19936.296672.828391@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00341.txt.bz2 > J. Johnston writes: > > The following changes the mi documentation to clarify the usage of the > > "--" delimeter. This delimeter is meant to provide a way to separate > > options from parameters so as to handle cases whereby the parameters may > > start with "-" and be mistaken for options. > > The problem reported tries to use it generally before any parameter list. > > This doesn't work because only the mi_getopt option processor knows to ignore it and > > commands that don't have options (preceded by dash) don't call mi_getopt. > > It is then treated as a parameter which is incorrect. > > I have removed the delimeter from the description of the -data-disassemble > > command as it is not manditory and the delimeter should be treated as optional to all > > applicable commands that support both options and parameters. I have removed > > it from one of the -data-disassemble examples to clarify that it may or may not > > be specified. The documentation is correct, there is no reason for changing it. All MI commands should use mi_getopt() as by doing this the MI can present a very consistent command line interface to its users. Contrast this to the UNIX and GDB CLI interfaces, each individual command has its own eseoteric edge conditions (and the user needs to work around each individually). The ``--'' problem is just one of the cases that mi_getopt() handles, another is c-strings (see below). In case you're wondering, the commands that don't use mi_getopt() pre-date that function's implementation (and one has gone back and updated them). For the most part converting commands to use mi_getopt() should be straight forward. There are exceptions though, some of the older commands pulled a very GDB CLI like hack by accepting: -command -opt x this is the "final" parameter when they should have accepted: -command -opt x -- "this is the \"final\" parameter" such a change will get messy and might mean replacing the command. > > Ok to commit? No. Andrew