From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <msnyder@redhat.com>
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Received: (qmail 19230 invoked from network); 11 Nov 2002 21:17:34 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 11 Nov 2002 21:17:34 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gABIQZw05624
	for <gdb-patches@sources.redhat.com>; Mon, 11 Nov 2002 13:26:35 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gABInYx02222;
	Mon, 11 Nov 2002 13:49:34 -0500
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id gABInXH32575;
	Mon, 11 Nov 2002 10:49:34 -0800
Message-ID: <3DCFFBBC.715EB616@redhat.com>
Date: Mon, 11 Nov 2002 17:15:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Richard.Earnshaw@arm.com
CC: gdb-patches@sources.redhat.com, cagney@redhat.com, kevinb@redhat.com
Subject: Re: [RFA] arm_store_return_value, big-endian (take 2)
References: <200211091154.gA9BsbA06176@pc960.cambridge.arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-11/txt/msg00320.txt.bz2

Richard Earnshaw wrote:
> 
> > Richard Earnshaw wrote:
> > >
> > > > Richard Earnshaw wrote:
> > > > >
> > > > > Leaving asside the issue of the correctness of write_register_bytes (note
> > > > > to self, must finish of my register patches), I don't think this is
> > > > > correct -- in fact, I think it's also wrong for little-endian as well.
> > > > >
> > > > > What should happen is that the smaller-than-word value should be
> > > > > zero/sign-extended to 32 bits and then the whole thing stored in A1_REGNUM.
> > > >
> > > > Ah, thanks.  OK, how about this?
> > > >
> > > > 2002-11-06  Michael Snyder  <msnyder@redhat.com>
> > > >
> > > >       * arm-tdep.c (arm_store_return_value): Handle offset of
> > > >       small types on big-endian machines.
> > >
> > > And for little-endian?
> >
> > It already works for little-endian.  I've tested this with
> > arm-sim, arm-sim/-mbig-endian, and arm-sim/-mthumb.
> 
> But it's not zero/sign extending properly for little-endian, so garbage is
> remaining in the top part of A1

Ah; well, I didn't make it any worse!  ;-)
Can I leave that detail for someone else, and just
submit this minor improvement?