From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28547 invoked by alias); 9 Nov 2002 00:00:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28540 invoked from network); 9 Nov 2002 00:00:58 -0000 Received: from unknown (HELO localhost.redhat.com) (216.129.200.2) by sources.redhat.com with SMTP; 9 Nov 2002 00:00:58 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C362F3FE4; Fri, 8 Nov 2002 19:01:00 -0500 (EST) Message-ID: <3DCC503C.1020102@redhat.com> Date: Fri, 08 Nov 2002 16:00:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Mark Kettenis Cc: drow@mvista.com, gdb-patches@sources.redhat.com Subject: Re: [patch rfc rfa:i386] Add i386 specific register groups References: <3DCBFA0C.70409@redhat.com> <86wunn6cea.fsf@elgar.kettenis.dyndns.org> <3DCC1F54.1000108@redhat.com> <200211082056.gA8Kudmd024760@elgar.kettenis.dyndns.org> <3DCC443A.1040902@redhat.com> <200211082314.gA8NEOLL015059@elgar.kettenis.dyndns.org> Content-Type: multipart/mixed; boundary="------------050401060902030009000904" X-SW-Source: 2002-11/txt/msg00267.txt.bz2 This is a multi-part message in MIME format. --------------050401060902030009000904 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 262 I've checked in the attached. Andrew > Date: Fri, 08 Nov 2002 18:09:46 -0500 > From: Andrew Cagney > > How does the attached look then? > > Great! Please go ahead and check in the code that produced this output. > > Mark > --------------050401060902030009000904 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 5494 2002-11-08 Andrew Cagney * i386-linux-tdep.c: Include "reggroups.h". (i386_linux_register_reggroup_p): New function. (i386_linux_init_abi): Set register_reggroup_p to i386_linux_register_reggroup_p. * i386-tdep.h (i386_register_reggroup_p): Declare. * i386-tdep.c: Include "reggroups.h". (i386_init_reggroups): New function. (i386_add_reggroups): New function. (i386_register_reggroup_p): New function. (i386_sse_reggroup, i386_mmx_reggroup): New variables. (_initialize_i386_tdep): Call i386_init_reggroups. (i386_gdbarch_init): Set register_reggroup_p and add in the i386 specific reggroups. Index: i386-linux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-linux-tdep.c,v retrieving revision 1.18 diff -u -r1.18 i386-linux-tdep.c --- i386-linux-tdep.c 31 Oct 2002 20:51:15 -0000 1.18 +++ i386-linux-tdep.c 8 Nov 2002 23:57:43 -0000 @@ -25,6 +25,7 @@ #include "value.h" #include "regcache.h" #include "inferior.h" +#include "reggroups.h" /* For i386_linux_skip_solib_resolver. */ #include "symtab.h" @@ -47,6 +48,20 @@ return i386_register_name (reg); } + +/* Return non-zero, when the register is in the corresponding register + group. Put the LINUX_ORIG_EAX register in the system group. */ +static int +i386_linux_register_reggroup_p (struct gdbarch *gdbarch, int regnum, + struct reggroup *group) +{ + if (regnum == I386_LINUX_ORIG_EAX_REGNUM) + return (group == system_reggroup + || group == save_reggroup + || group == restore_reggroup); + return i386_register_reggroup_p (gdbarch, regnum, group); +} + /* Recognizing signal handler frames. */ @@ -442,6 +457,7 @@ set_gdbarch_write_pc (gdbarch, i386_linux_write_pc); set_gdbarch_num_regs (gdbarch, I386_SSE_NUM_REGS + 1); set_gdbarch_register_name (gdbarch, i386_linux_register_name); + set_gdbarch_register_reggroup_p (gdbarch, i386_linux_register_reggroup_p); set_gdbarch_register_bytes (gdbarch, I386_SSE_SIZEOF_REGS + 4); tdep->jb_pc_offset = 20; /* From . */ Index: i386-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.c,v retrieving revision 1.93 diff -u -r1.93 i386-tdep.c --- i386-tdep.c 8 Nov 2002 17:34:31 -0000 1.93 +++ i386-tdep.c 8 Nov 2002 23:57:43 -0000 @@ -37,6 +37,7 @@ #include "doublest.h" #include "value.h" #include "gdb_assert.h" +#include "reggroups.h" #include "i386-tdep.h" #include "i387-tdep.h" @@ -1443,6 +1444,56 @@ } +/* i386 register groups. In addition to the normal groups, add "mmx" + and "sse". */ + +static struct reggroup *i386_sse_reggroup; +static struct reggroup *i386_mmx_reggroup; + +static void +i386_init_reggroups (void) +{ + i386_sse_reggroup = reggroup_new ("sse", USER_REGGROUP); + i386_mmx_reggroup = reggroup_new ("mmx", USER_REGGROUP); +} + +static void +i386_add_reggroups (struct gdbarch *gdbarch) +{ + reggroup_add (gdbarch, i386_sse_reggroup); + reggroup_add (gdbarch, i386_mmx_reggroup); + reggroup_add (gdbarch, general_reggroup); + reggroup_add (gdbarch, float_reggroup); + reggroup_add (gdbarch, all_reggroup); + reggroup_add (gdbarch, save_reggroup); + reggroup_add (gdbarch, restore_reggroup); + reggroup_add (gdbarch, vector_reggroup); + reggroup_add (gdbarch, system_reggroup); +} + +int +i386_register_reggroup_p (struct gdbarch *gdbarch, int regnum, + struct reggroup *group) +{ + int sse_regnum_p = (i386_sse_regnum_p (regnum) + || i386_mxcsr_regnum_p (regnum)); + int fp_regnum_p = (i386_fp_regnum_p (regnum) + || i386_fpc_regnum_p (regnum)); + int mmx_regnum_p = (i386_mmx_regnum_p (regnum)); + if (group == i386_mmx_reggroup) + return mmx_regnum_p; + if (group == i386_sse_reggroup) + return sse_regnum_p; + if (group == vector_reggroup) + return (mmx_regnum_p || sse_regnum_p); + if (group == float_reggroup) + return fp_regnum_p; + if (group == general_reggroup) + return (!fp_regnum_p && !mmx_regnum_p && !sse_regnum_p); + return default_register_reggroup_p (gdbarch, regnum, group); +} + + static struct gdbarch * i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) { @@ -1601,6 +1652,10 @@ set_gdbarch_print_insn (gdbarch, i386_print_insn); + /* Add the i386 register groups. */ + i386_add_reggroups (gdbarch); + set_gdbarch_register_reggroup_p (gdbarch, i386_register_reggroup_p); + /* Hook in ABI-specific overrides, if they have been registered. */ gdbarch_init_osabi (info, gdbarch, osabi); @@ -1671,4 +1726,7 @@ i386_go32_init_abi); gdbarch_register_osabi (bfd_arch_i386, GDB_OSABI_NETWARE, i386_nw_init_abi); + + /* Initialize the i386 specific register groups. */ + i386_init_reggroups (); } Index: i386-tdep.h =================================================================== RCS file: /cvs/src/src/gdb/i386-tdep.h,v retrieving revision 1.18 diff -u -r1.18 i386-tdep.h --- i386-tdep.h 8 Nov 2002 23:35:14 -0000 1.18 +++ i386-tdep.h 8 Nov 2002 23:57:43 -0000 @@ -167,6 +167,10 @@ /* Return the name of register REG. */ extern char const *i386_register_name (int reg); +/* Return non-zero if REGNUM is a member of the specified group. */ +extern int i386_register_reggroup_p (struct gdbarch *gdbarch, int regnum, + struct reggroup *group); + /* Initialize a basic ELF architecture variant. */ extern void i386_elf_init_abi (struct gdbarch_info, struct gdbarch *); --------------050401060902030009000904--