From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11010 invoked by alias); 8 Nov 2002 19:37:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11003 invoked from network); 8 Nov 2002 19:37:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 8 Nov 2002 19:37:07 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gA8JEIw02864 for ; Fri, 8 Nov 2002 14:14:18 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA8Jawl25586; Fri, 8 Nov 2002 14:36:58 -0500 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id gA8JavD08328; Fri, 8 Nov 2002 11:36:58 -0800 Message-ID: <3DCC1259.12A90AF0@redhat.com> Date: Fri, 08 Nov 2002 11:37:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com CC: gdb-patches@sources.redhat.com, cagney@redhat.com, kevinb@redhat.com Subject: Re: [RFA] arm_store_return_value, big-endian (take 2) References: <200211080957.gA89vMV18298@pc960.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00233.txt.bz2 Richard Earnshaw wrote: > > > Richard Earnshaw wrote: > > > > > > Leaving asside the issue of the correctness of write_register_bytes (note > > > to self, must finish of my register patches), I don't think this is > > > correct -- in fact, I think it's also wrong for little-endian as well. > > > > > > What should happen is that the smaller-than-word value should be > > > zero/sign-extended to 32 bits and then the whole thing stored in A1_REGNUM. > > > > Ah, thanks. OK, how about this? > > > > 2002-11-06 Michael Snyder > > > > * arm-tdep.c (arm_store_return_value): Handle offset of > > small types on big-endian machines. > > And for little-endian? It already works for little-endian. I've tested this with arm-sim, arm-sim/-mbig-endian, and arm-sim/-mthumb.