> Andrew Cagney <ac131313@redhat.com> writes:
> 
> 
> The attached:
> 
> - converts all the macro's into functions
> 
> - makes the function checks more robust - return true when both the regnum matches and the ISA has the register
> 
> - adds a method to test for the orig_eax register (the I386_LINUX_ORIG_EAX_REGNUM is moved from i386-linux-tdep.h to i386-tdep.h).
> 
> Ok to commit?
> 
> 
> Looks good, but why the move of the Linux orig_eax register test to
> i386-tdep.{c|h}?  I'd really keep this Linux-specific quirk isolated
> in a Linux-specific file.
> 
> I'd two choices:
> 
> - move ORIG_EAX into i386-tdep.c so that (in the next patch) i386_register_reggroup_p() can use it
> - make i386_register_reggroup_p() a global so that a i386_linux_register_reggroup_p() can call it
> 
> I took the first one.  I'll re-arange things so that my follow on patch uses the second method instead.
> 
> Ok with that change.  Otherwise we might need to discuss this a bit more ;-).

FYI, I've checked in the attached.  It leaves the 
I386_LINUX_ORIG_EAX_REGNUM stuff untouched.

Andrew