From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19610 invoked by alias); 7 Nov 2002 01:40:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19602 invoked from network); 7 Nov 2002 01:40:44 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 7 Nov 2002 01:40:44 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 468793CD3; Wed, 6 Nov 2002 20:40:45 -0500 (EST) Message-ID: <3DC9C49D.2090801@redhat.com> Date: Wed, 06 Nov 2002 17:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: cgd@broadcom.com Cc: rsandifo@redhat.com, gdb-patches@sources.redhat.com Subject: Re: sim/mips patch: add support for more NEC VR targets References: <3DC9B7CF.8050401@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00160.txt.bz2 > At Wed, 06 Nov 2002 19:46:07 -0500, Andrew Cagney wrote: > >> >> - gen-engine.c adds the global prefix to the beginning of >> >> ENGINE_ISSUE_(PREFIX|POSTFIX)_HOOK. It seems MIPS is the >> >> only back-end to define these macros, and it never adds a >> >> prefix. The patch adjusts igen accordingly. > >> > >> > >> > Hmm. I don't know igen so well. Andrew? What are your thoughts >> > here? > >> >> [I suspect its already been committed] >> So, how did it ever build? > > > Err, well, build is no problem: the code in question did #if > defined(%sENGINE_ISSUE_PREFIX_HOOK)... so it won't get in there. > > > >> Specify two functions. One for the mips5500 and one for the rest. That >> way, there isn't any reason for adding TATE_ARCHITECTURE (SD)->mach == >> bfd_mach_mips5500. >> >> It will also solve the default machine problem. > > > well: > > (1) w/ separate fn, you'd need to tag _all_ of the 5500 machine insns > w/ mips5500. (as opposed to ISA + a few mips5500 extensions.) Er, all the instructions that belonged to the MIPS 5500 should be taged with 5500 anyway. As I noted: > The real world order is: ISA YYY implements MIPS XXX, BUT with a few tiny exceptions .... You end up having to check that every single *&@^#$(*&@#$ instruction matches the generic ISA. Sigh. Andrew