From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19881-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 32046 invoked by alias); 6 Nov 2002 22:37:00 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32038 invoked from network); 6 Nov 2002 22:36:59 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 6 Nov 2002 22:36:59 -0000
Received: from redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 71DBB3CC5; Wed,  6 Nov 2002 17:37:01 -0500 (EST)
Message-ID: <3DC9998D.6030603@redhat.com>
Date: Wed, 06 Nov 2002 14:37:00 -0000
From: Andrew Cagney <ac131313@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Klee Dienes <klee@apple.com>
Cc: Daniel Jacobowitz <drow@mvista.com>,
	gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Use read_memory_unsigned_integer when reading to CORE_ADDR
References: <038EC655-F071-11D6-8361-00039396EEB8@apple.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-11/txt/msg00137.txt.bz2

> I used extract_type_address to honor the comment about not causing a memory_error.
> 
> I'll check in the change from builtin_type_void_data_ptr to builtin_type_void_code_ptr.

Thanks!

> Unless someone objects, I'll also change
> 
>   int ptrbytes = TARGET_PTR_BIT / TARGET_CHAR_BIT;
> 
> to
> 
>   int ptrbytes = TYPE_LENGTH (builtin_type_void_code_ptr);

Now this I like so much, I'm going to add it to the ARI as a recommendation.

Andrew