From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28227 invoked by alias); 6 Nov 2002 18:34:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28212 invoked from network); 6 Nov 2002 18:34:19 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 6 Nov 2002 18:34:19 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 556803E60; Wed, 6 Nov 2002 13:34:21 -0500 (EST) Message-ID: <3DC960AD.8010603@redhat.com> Date: Wed, 06 Nov 2002 10:34:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Cagney Cc: Jim Blandy , gdb-patches@sources.redhat.com Subject: Re: RFA: Tolerate filenames present in symtabs but absent from macro info References: <3DC95E55.4070801@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00108.txt.bz2 > ! (__FILE__, __LINE__, > ! "\n" > ! "the symtab `%s' refers to a preprocessor macro table which doesn't\n" > > > What's the "\n" for? The sentence should also start with a capital (and probably not end in a full-stop). Hmm, oops, PS. > ! ms->file = macro_lookup_inclusion (main, sal.symtab->filename); > > ! if (! ms->file) > ! internal_error > ! (__FILE__, __LINE__, > ! "\n" > ! "the symtab `%s' refers to a preprocessor macro table which doesn't\n" > ! "have any record of processing a file by that name.\n", > ! sal.symtab->filename); > ! > ! ms->line = sal.line; Is this an error? The problem is caused by invalid input and not GDB's internal state being somehow corrupt. (Daniel's suggestion about gdb-test is a good idea.) Andrew