From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17967 invoked by alias); 23 Oct 2002 22:20:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17958 invoked from network); 23 Oct 2002 22:20:16 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 23 Oct 2002 22:20:16 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id E68F280007A; Wed, 23 Oct 2002 18:20:15 -0400 (EDT) Message-ID: <3DB7209F.B1AC2251@redhat.com> Date: Wed, 23 Oct 2002 15:20:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. X-Accept-Language: en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Cc: ac131313@redhat.com Subject: Re: Patch for gdb/mi problem 702 References: Content-Type: multipart/mixed; boundary="------------0DD54D6A05EA596CF6F8E0DC" X-SW-Source: 2002-10/txt/msg00482.txt.bz2 This is a multi-part message in MIME format. --------------0DD54D6A05EA596CF6F8E0DC Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 461 I have added test scenarios to gdb.mi testsuite to verify the new assign/update behavior. gdb/testsuite/gdb.mi/ChangeLog 2002-10-23 Jeff Johnston * mi-var-cmd.exp: Add tests to verify that a -var-assign that changes a value shows up in the changelist of a -var-update. * mi1-var-cmd.exp: Ditto. Andrew, are you satisfied with my answer to your previous question and may I commit the original patch plus these changes? -- Jeff J. --------------0DD54D6A05EA596CF6F8E0DC Content-Type: text/plain; charset=us-ascii; name="702.test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="702.test.patch" Content-length: 2781 Index: mi-var-cmd.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-cmd.exp,v retrieving revision 1.13 diff -u -r1.13 mi-var-cmd.exp --- mi-var-cmd.exp 3 Oct 2002 20:03:55 -0000 1.13 +++ mi-var-cmd.exp 23 Oct 2002 22:12:48 -0000 @@ -288,6 +288,18 @@ "\\^done,value=\"3333\"" \ "assign to linteger" +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\\\[\{name=\"linteger\",in_scope=\"true\",type_changed=\"false\"\}\\\]" \ + "update all vars: linteger changed after assign" + +mi_gdb_test "-var-assign linteger 3333" \ + "\\^done,value=\"3333\"" \ + "assign to linteger again, same value" + +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\\\[\\\]" \ + "update all vars: linteger not changed after same assign" + mi_gdb_test "-var-evaluate-expression linteger" \ "\\^done,value=\"3333\"" \ "eval linteger" @@ -295,6 +307,14 @@ mi_gdb_test "-var-assign lpinteger \"&linteger + 3\"" \ "\\^done,value=\"$hex\"" \ "assign to lpinteger" + +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\\\[\{name=\"lpinteger\",in_scope=\"true\",type_changed=\"false\"\}\\\]" \ + "update all vars: lpinteger changed after assign" + +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\\\[\\\]" \ + "update all vars: no changes on second update" mi_gdb_test "-var-evaluate-expression lpinteger" \ "\\^done,value=\"$hex\"" \ Index: mi1-var-cmd.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi1-var-cmd.exp,v retrieving revision 1.2 diff -u -r1.2 mi1-var-cmd.exp --- mi1-var-cmd.exp 1 Oct 2002 16:01:37 -0000 1.2 +++ mi1-var-cmd.exp 23 Oct 2002 22:12:48 -0000 @@ -288,6 +288,18 @@ "\\^done,value=\"3333\"" \ "assign to linteger" +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\{name=\"linteger\",in_scope=\"true\",type_changed=\"false\"\}" \ + "update all vars: linteger changed after assign" + +mi_gdb_test "-var-assign linteger 3333" \ + "\\^done,value=\"3333\"" \ + "reassign to linteger" + +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\{\}" \ + "update all vars: linteger not changed after same assign" + mi_gdb_test "-var-evaluate-expression linteger" \ "\\^done,value=\"3333\"" \ "eval linteger" @@ -295,6 +307,14 @@ mi_gdb_test "-var-assign lpinteger \"&linteger + 3\"" \ "\\^done,value=\"$hex\"" \ "assign to lpinteger" + +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\{name=\"lpinteger\",in_scope=\"true\",type_changed=\"false\"\}" \ + "update all vars: lpinteger changed after assign" + +mi_gdb_test "-var-update *" \ + "\\^done,changelist=\{\}" \ + "update all vars: no changes for second update" mi_gdb_test "-var-evaluate-expression lpinteger" \ "\\^done,value=\"$hex\"" \ --------------0DD54D6A05EA596CF6F8E0DC--