From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31680 invoked by alias); 23 Oct 2002 21:37:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31670 invoked from network); 23 Oct 2002 21:37:17 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 23 Oct 2002 21:37:17 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9NLFpw19858 for ; Wed, 23 Oct 2002 17:15:51 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9NLbAl10408; Wed, 23 Oct 2002 17:37:10 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g9NLb9D26227; Wed, 23 Oct 2002 14:37:09 -0700 Message-ID: <3DB71685.2BFAFE2@redhat.com> Date: Wed, 23 Oct 2002 14:37:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: Andrew Cagney , Adam Fedor , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> <3DA37857.466240D9@redhat.com> <3DB4811E.5080106@redhat.com> <3DB6F744.410DB743@redhat.com> <3DB6FA28.1080304@redhat.com> <20021023201113.GA22053@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00479.txt.bz2 Daniel Jacobowitz wrote: > > On Wed, Oct 23, 2002 at 03:36:08PM -0400, Andrew Cagney wrote: > > >> > > > > > >>> - error ("no args, no `this'"); > > > > > >>>> + error ("no args, no %s", name); > > > > > >> > > >>Michael, > > >> > > >>This changes GDB's behavior. Instead of printing: > > >> > > >> no args, no `this' > > >>it will print > > >> no args, no this > > >> > > >>I don't think GDB's output should be changed in this way. > > >>(I'm suprized that running the testsuite didn't detect this). > > > > > > > > >Hi Andrew, > > > > > >I corrected this with the patch below. I did not add a new test, > > >because I cannot find a way to invoke this error message. ;-/ > > > > Michael, my memory of the Apple patch is that it changed this > > everywhere, the above was just one example :-( (btw `this' not 'this'). > > By the way, GCC recently reached the consensus that '' and "" were > appropriate quote marks, and that `' should go away. Very sensable, IMHO. > [Although I think they also decided that `' should be left in the > source and transliterated by the output routines; that way we can > generate proper quotes in locales which have them. Or maybe that the > real Unicode quotes should be used in source and transliterated to ''.]