From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31255 invoked by alias); 23 Oct 2002 21:35:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31241 invoked from network); 23 Oct 2002 21:35:03 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 23 Oct 2002 21:35:03 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9NLDcw19357 for ; Wed, 23 Oct 2002 17:13:38 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9NLZ1l10356; Wed, 23 Oct 2002 17:35:01 -0400 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g9NLYtD26165; Wed, 23 Oct 2002 14:34:55 -0700 Message-ID: <3DB715FF.586B59C9@redhat.com> Date: Wed, 23 Oct 2002 14:35:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Andrew Cagney CC: Adam Fedor , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> <3DA37857.466240D9@redhat.com> <3DB4811E.5080106@redhat.com> <3DB6F744.410DB743@redhat.com> <3DB6FA28.1080304@redhat.com> Content-Type: multipart/mixed; boundary="------------939A438BC252F05014C73B76" X-SW-Source: 2002-10/txt/msg00478.txt.bz2 This is a multi-part message in MIME format. --------------939A438BC252F05014C73B76 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 956 Andrew Cagney wrote: > > >> > > > >> > - error ("no args, no `this'"); > > > >> >> + error ("no args, no %s", name); > > > >> > >> Michael, > >> > >> This changes GDB's behavior. Instead of printing: > >> > >> no args, no `this' > >> it will print > >> no args, no this > >> > >> I don't think GDB's output should be changed in this way. > >> (I'm suprized that running the testsuite didn't detect this). > > > > > > Hi Andrew, > > > > I corrected this with the patch below. I did not add a new test, > > because I cannot find a way to invoke this error message. ;-/ > > Michael, my memory of the Apple patch is that it changed this > everywhere, the above was just one example :-( Oh. Why didn't you say so? OK, below are all the ones I could find. > (btw `this' not 'this'). Pretty picky, for something that never showed up in a testsuite. OK, I'll change it to using that quote that nobody ever uses... See below. --------------939A438BC252F05014C73B76 Content-Type: text/plain; charset=us-ascii; name="this2.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="this2.diff" Content-length: 2824 2002-10-23 Michael Snyder * printcmd.c (address_info): Restore quotes in output. * valops.c (value_of_local): Restore quotes in error message. Index: printcmd.c =================================================================== RCS file: /cvs/src/src/gdb/printcmd.c,v retrieving revision 1.46 diff -p -r1.46 printcmd.c *** printcmd.c 21 Oct 2002 19:11:50 -0000 1.46 --- printcmd.c 23 Oct 2002 21:27:36 -0000 *************** address_info (char *exp, int from_tty) *** 1106,1114 **** current_language->la_language, DMGL_ANSI); printf_filtered ("\" is a field of the local class variable "); if (current_language->la_language == language_objc) ! printf_filtered ("'self'\n"); /* ObjC equivalent of "this" */ else ! printf_filtered ("'this'\n"); return; } --- 1106,1114 ---- current_language->la_language, DMGL_ANSI); printf_filtered ("\" is a field of the local class variable "); if (current_language->la_language == language_objc) ! printf_filtered ("`self'\n"); /* ObjC equivalent of "this" */ else ! printf_filtered ("`this'\n"); return; } Index: valops.c =================================================================== RCS file: /cvs/src/src/gdb/valops.c,v retrieving revision 1.77 diff -p -r1.77 valops.c *** valops.c 23 Oct 2002 19:22:28 -0000 1.77 --- valops.c 23 Oct 2002 21:27:38 -0000 *************** value_of_local (const char *name, int co *** 3330,3336 **** if (!func) { if (complain) ! error ("no %s in nameless context", name); else return 0; } --- 3330,3336 ---- if (!func) { if (complain) ! error ("no `%s' in nameless context", name); else return 0; } *************** value_of_local (const char *name, int co *** 3340,3346 **** if (i <= 0) { if (complain) ! error ("no args, no '%s'", name); else return 0; } --- 3340,3346 ---- if (i <= 0) { if (complain) ! error ("no args, no `%s'", name); else return 0; } *************** value_of_local (const char *name, int co *** 3351,3364 **** if (sym == NULL) { if (complain) ! error ("current stack frame does not contain a variable named \"%s\"", name); else return NULL; } ret = read_var_value (sym, selected_frame); if (ret == 0 && complain) ! error ("%s argument unreadable", name); return ret; } --- 3351,3364 ---- if (sym == NULL) { if (complain) ! error ("current stack frame does not contain a variable named `%s'", name); else return NULL; } ret = read_var_value (sym, selected_frame); if (ret == 0 && complain) ! error ("`%s' argument unreadable", name); return ret; } --------------939A438BC252F05014C73B76--