From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18221 invoked by alias); 22 Oct 2002 00:07:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18208 invoked from network); 22 Oct 2002 00:07:26 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 22 Oct 2002 00:07:26 -0000 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id E6165800084 for ; Mon, 21 Oct 2002 20:07:25 -0400 (EDT) Message-ID: <3DB496BD.E55975B1@redhat.com> Date: Mon, 21 Oct 2002 17:07:00 -0000 From: "J. Johnston" Organization: Red Hat Inc. X-Accept-Language: en MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: RFA: change for gdb/mi 495 Content-Type: multipart/mixed; boundary="------------30EE851E0F3766DFA0022F8E" X-SW-Source: 2002-10/txt/msg00371.txt.bz2 This is a multi-part message in MIME format. --------------30EE851E0F3766DFA0022F8E Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 289 The following is a patch for gdb/mi 495. The PR requests changing ui_out_field_core_addr to use core_addr_to_string(). Ok to commit? -- Jeff J. gdb/ChangeLog: 2002-10-21 Jeff Johnston * ui-out.c (ui_out_field_core_addr): Change to call core_addr_to_string(). --------------30EE851E0F3766DFA0022F8E Content-Type: text/plain; charset=us-ascii; name="495.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="495.patch" Content-length: 859 Index: ui-out.c =================================================================== RCS file: /cvs/src/src/gdb/ui-out.c,v retrieving revision 1.24 diff -u -r1.24 ui-out.c --- ui-out.c 3 Oct 2002 22:34:58 -0000 1.24 +++ ui-out.c 22 Oct 2002 00:02:17 -0000 @@ -507,16 +507,7 @@ const char *fldname, CORE_ADDR address) { - char addstr[20]; - - /* FIXME: cagney/2002-05-03: Need local_address_string() function - that returns the language localized string formatted to a width - based on TARGET_ADDR_BIT. */ - /* print_address_numeric (address, 1, local_stream); */ - if (TARGET_ADDR_BIT <= 32) - strcpy (addstr, local_hex_string_custom (address, "08l")); - else - strcpy (addstr, local_hex_string_custom (address, "016l")); + const char *addstr = core_addr_to_string (address); ui_out_field_string (uiout, fldname, addstr); } --------------30EE851E0F3766DFA0022F8E--