Re: [PATCH] Objective-C language support.

Michael Snyder
2002-10-09T00:19:47Z

Adam Fedor wrote:
>
> This patch adds Objective-C language support to gdb based upon a patch
> provided by Apple Computer Inc from their version of gdb. Note that the
> patch only contains changes to existing files. New files (objc-lang.h,
> objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at
>
> ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz

Adam, this is approved, but do you think you could make
the comment a little more informative? And Capitolize "Also"
and add a period.

> * breakpoint.c (parse_breakpoint_sals): Ignore ObjC method
> names when checking default.
>
> Index: gdb/breakpoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/breakpoint.c,v
> retrieving revision 1.86
> diff -u -p -r1.86 breakpoint.c
> --- gdb/breakpoint.c 5 Sep 2002 01:28:14 -0000 1.86
> +++ gdb/breakpoint.c 17 Sep 2002 19:29:52 -0000
> @@ -4618,9 +4618,11 @@ parse_breakpoint_sals (char **address,
> current_source_symtab (which is decode_line_1's default). This
> should produce the results we want almost all of the time while
> leaving default_breakpoint_* alone. */
> + /* also ignore objc method name */
> if (default_breakpoint_valid
> && (!current_source_symtab
> - || (strchr ("+-", (*address)[0]) != NULL)))
> + || ((strchr ("+-", (*address)[0]) != NULL)
> + && ((*address)[1] != '['))))
> *sals = decode_line_1 (address, 1, default_breakpoint_symtab,
> default_breakpoint_line, addr_string);
> else