From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6865 invoked by alias); 21 Oct 2002 19:08:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6715 invoked from network); 21 Oct 2002 19:08:44 -0000 Received: from unknown (HELO touchme.toronto.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 21 Oct 2002 19:08:44 -0000 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 63742800084 for ; Mon, 21 Oct 2002 15:08:43 -0400 (EDT) Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C909E3EEC; Mon, 21 Oct 2002 15:05:31 -0400 (EDT) Message-ID: <3DB44FFB.2090205@redhat.com> Date: Mon, 21 Oct 2002 12:08:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Klee Dienes Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Use read_memory_unsigned_integer when reading to CORE_ADDR References: <7E7F8836-D94A-11D6-9563-00039396EEB8@apple.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00344.txt.bz2 > /* Don't cause a memory_error when accessing sigcontext in case the stack > layout has changed or the stack is corrupt. */ > target_read_memory (sigcontext_addr + SIGCONTEXT_PC_OFFSET, buf, ptrbytes); > - return extract_unsigned_integer (buf, ptrbytes); > + return extract_typed_address (buf, builtin_type_void_data_ptr); This should be builtin_type_void_code_ptr since it is extracting a code pointer (the PC). It, also, might as well use read_memory_typed_address(). Andrew