From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8964 invoked by alias); 18 Oct 2002 22:54:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8919 invoked from network); 18 Oct 2002 22:53:59 -0000 Received: from unknown (63.119.183.65) by sources.redhat.com with QMTP; 18 Oct 2002 22:53:59 -0000 Received: (qmail 24852 invoked from network); 18 Oct 2002 22:49:07 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO doc.com) (24.221.209.215) by external1 with SMTP; 18 Oct 2002 22:49:07 -0000 Message-ID: <3DB09113.9070205@doc.com> Date: Fri, 18 Oct 2002 15:54:00 -0000 From: Adam Fedor Organization: Digital Optics Corp. User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.0.0) Gecko/20020610 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Elena Zannoni CC: Jim Blandy , Klee Dienes , Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Redefine skip_quoted References: <95706CBA-DFBC-11D6-A1B6-00039396EEB8@apple.com> <3DAF2C71.6030908@doc.com> <15792.33251.884402.152637@localhost.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00312.txt.bz2 Elena Zannoni wrote: > Adam Fedor writes: > > Jim Blandy wrote: > > > Klee Dienes writes: > > > > > >>In the Apple code, we use skip_quoted to allow for the possibility of > > >>spaces in Objective-C function names. > > >> > > >>I'm actually coming to think that allowing people to break on unquoted > > >>Objective-C methods was a mistake: it's caused us no end of trouble > > >>trying to shoehorn decode_line_1() into handling every possible > > >>edge-case. I'm not sure how practical it is for us to remove it at > > >>this point, though --- we'd have to do some research among our > > >>Objective-C developers to find out how important a feature it is to > > >>them, I think. > > > > > > > > > So, the original patch posted is preparation for a behavior which you > > > now suspect was a mistake, and which has caused you no end of trouble? > > > (Or do I have the sense of what you were saying reversed?) You can > > > forgive me if hearing that makes me a bit hesitant to approve the > > > patch, right? :) > > > > > > > Well, really the use of skip_quoted for ObjC (in a patch that I haven't > > submitted yet), really has more to do with handling the canonical form > > of an Objective-C method symbol (e.g. -[MyObject myMethod:arg2:]) that > > comes from objc-lang.c. Most of the breakpoint cases that a user would > > enter are handled elsewhere (in a patch that I also haven't submitted). > > > > I have to agree with Jim here, I think we should wait on the parts you > haven't submitted before deciding on this one. Could you just have > added the chars you need to the gdb_completer_word_break_characters > variable? > No. It involves removing characters. Another option would be to define a new function, say skip_objc_quoted, just for objc which would be similar to skip_quoted. How about that? -- Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because http://www.doc.com | if I didn't, I'd eat it, and you | know how I hate the stuff.