From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23375 invoked by alias); 18 Oct 2002 17:06:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23339 invoked from network); 18 Oct 2002 17:06:49 -0000 Received: from unknown (63.119.183.65) by sources.redhat.com with QMTP; 18 Oct 2002 17:06:49 -0000 Received: (qmail 12367 invoked from network); 18 Oct 2002 17:01:56 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO doc.com) (24.221.209.215) by external1 with SMTP; 18 Oct 2002 17:01:56 -0000 Message-ID: <3DB03FB3.20005@doc.com> Date: Fri, 18 Oct 2002 10:06:00 -0000 From: Adam Fedor Organization: Digital Optics Corp. User-Agent: Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.0.0) Gecko/20020610 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jim Blandy CC: Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Objective-C language support. References: <3D889A97.90202@doc.com> <3DA37187.57F232FE@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-10/txt/msg00300.txt.bz2 Nobody I know can figure out what this does, so for now I'll just drop it and see if something goes wrong... Jim Blandy wrote: > Can we have a more extensive comment here? What are symbols that > begin with ".objc_"? Why should we ignore them? Where can we find > more complete documentation for what they mean? (Is there any > document that describes how Objective C programs are represented at > the assembly/linkage level?) > > Michael Snyder writes: > > >>Adam Fedor wrote: >> >>>This patch adds Objective-C language support to gdb based upon a patch >>>provided by Apple Computer Inc from their version of gdb. Note that the >>>patch only contains changes to existing files. New files (objc-lang.h, >>>objc-lang.c, objc-exp.y) and a gdb.objc testsuite directory are located at >>> >>>ftp://ftp.gnustep.org/pub/gnustep/contrib/gdb-objc-patch.tar.gz >>> >> >>Jim, could you take a quick look at this small change? >>[Adam, the comment needs a period followed by two spaces.] >> >> >> >>> * elfread.c (elf_symtab_read): Skip ObjC symbols. >> >>>Index: gdb/elfread.c >>>=================================================================== >>>RCS file: /cvs/src/src/gdb/elfread.c,v >>>retrieving revision 1.23 >>>diff -u -p -r1.23 elfread.c >>>--- gdb/elfread.c 24 Jul 2002 23:51:35 -0000 1.23 >>>+++ gdb/elfread.c 17 Sep 2002 19:29:59 -0000 >>>@@ -349,7 +349,12 @@ elf_symtab_read (struct objfile *objfile >>> } >>> else if (sym->section->flags & SEC_CODE) >>> { >>>- if (sym->flags & BSF_GLOBAL) >>>+ if (sym->name[0] == '.' && (strncmp (sym->name + 1, "objc_", 4) == 0)) >>>+ { >>>+ /* Looks like an Objective-C special symbol */ >>>+ continue; >>>+ } >>>+ else if (sym->flags & BSF_GLOBAL) >>> { >>> ms_type = mst_text; >>> } >> -- Adam Fedor, Digital Optics Corp. | I'm glad I hate spinach, because http://www.doc.com | if I didn't, I'd eat it, and you | know how I hate the stuff.